From 466f610cee6144467f8dcf527a493222d3444a5b Mon Sep 17 00:00:00 2001
From: mrizzi <mrizzi@redhat.com>
Date: Wed, 24 Apr 2024 17:59:15 +0200
Subject: [PATCH] Case sensitive management for input options keys

Signed-off-by: mrizzi <mrizzi@redhat.com>
---
 cmd/verify.go                                 |   2 +-
 cmd/verify_test.go                            |  22 ++++++++++++++++++
 ...1.0-v3.with-additionalproperties-false.tgz | Bin 0 -> 1028 bytes
 3 files changed, 23 insertions(+), 1 deletion(-)
 create mode 100644 internal/chartverifier/checks/chart-0.1.0-v3.with-additionalproperties-false.tgz

diff --git a/cmd/verify.go b/cmd/verify.go
index 829a10c4..6c152f2e 100644
--- a/cmd/verify.go
+++ b/cmd/verify.go
@@ -110,7 +110,7 @@ func convertToMap(values []string) map[string]interface{} {
 	valueMap := make(map[string]interface{})
 	for _, val := range values {
 		parts := strings.SplitN(val, "=", 2)
-		valueMap[strings.ToLower(parts[0])] = parts[1]
+		valueMap[parts[0]] = parts[1]
 	}
 	return valueMap
 }
diff --git a/cmd/verify_test.go b/cmd/verify_test.go
index 3439443d..2938a6fd 100644
--- a/cmd/verify_test.go
+++ b/cmd/verify_test.go
@@ -114,6 +114,28 @@ func TestCertify(t *testing.T) {
 				require.Contains(t, output.String(), expected)
 			},
 		},
+		{
+			name: "Should succeed when the chart exists and a chart value is overridden",
+			args: []string{
+				"-e", "helm-lint",
+				"-S", "replicaCount=2",
+				"-E",
+				"../internal/chartverifier/checks/chart-0.1.0-v3.with-additionalproperties-false.tgz",
+			},
+			validateErrorFunc: func(err error) {
+				require.NoError(t, err)
+			},
+			validateOutputFunc: func(output *bytes.Buffer) {
+				require.NotEmpty(t, output.String())
+
+				expected := "results:\n" +
+					"    - check: v1.0/helm-lint\n" +
+					"      type: Mandatory\n" +
+					"      outcome: PASS\n" +
+					"      reason: Helm lint successful\n"
+				require.Contains(t, output.String(), expected)
+			},
+		},
 		{
 			name: "Should display JSON certificate when option --output and argument values are given",
 			args: []string{
diff --git a/internal/chartverifier/checks/chart-0.1.0-v3.with-additionalproperties-false.tgz b/internal/chartverifier/checks/chart-0.1.0-v3.with-additionalproperties-false.tgz
new file mode 100644
index 0000000000000000000000000000000000000000..d26bc6390e1302f137fd1f96b16c6691bd8d3087
GIT binary patch
literal 1028
zcmV+f1pE6RiwFS6C@E$D1MOICZ`(Ey?q~iAP8raxh$+gigMkeg+yM=SZN@TWABJI|
zC0b%bkt|8sb&Bq{?@0MAZWj+|lQpO>044G6o;%5Wj>qH`vp$`Kk*ruPpWK5`N{9VE
zhHEw&(EV#GJvzi$f0%W<-F|n}!!#SvE`5UOeI#=zjq}VxDzz0iH{##zj_KQ1!Q1O2
z5oW{{w@zp^#)~du#%v!mk_`z(1$Vg>#>ctu@e3|%oQL&-=i1^Qn;Ex?d+w0PgGJ@N
zapN>yE|-MAX0?%=<ho9yODEV6qe^rQe%nY-zxy^LT}tRvq*%?zEk5!q1NV@U6gdm=
z(PHC4Nk(XA(IX2cMS=eBulRT+e(4mxV#D2i6@VT8Z&PH)|K5iGJvtZy|GNV^cwqj2
zD9$70zo=Qs#|VS8)HB-o(sK7ob~4(r6_=x^wH!3UYr7ib#PU)&Z&!rnId_g&UR2CS
zp4-ahGEJh7X{4NLU@!Pw%zxH?3cy_XsPwD^q^y$-vt&*CWEVU^Mq59|-%w<%_Bz+H
ztt|)=3H4y28wL6doyh+oa*O{iuXxSKOQ+SxjB$kjS)X<f_}?21`X~NBguDSRCSSHc
zd;$#IY~NuGbk^%Z+cGUIoBIwOrS05VavmI6QHZcHGdZ=|aO(wkfHG&&@n~T7r{6^0
zC$Z#gA7Nsz!w4x%wDL?SZt+F5Jm1*82Q1Eq(sXME=0fifz@SPARVG{2+w+|tRG|Ot
zh7R1fmU{M*=f1UEYm-pT?s&mVZWkiwvEU}}0Pct00ESw42jDcQw?MT}qHbzX(09Ov
z^1S5s0DWCx_aoeu&3*;GBdcFqGl%nN_@4Z-Bl(2^t>Z$}SB-#;2F(6A$b0`Q!R?>X
z-U}}y=2a|i?Sei0)!u&Y+ecgfJ%>J>K@*=se?Avw&CEw^29NcBS^u#A8^GVG{y&7=
zI{#(pTBu@-Cvg${#0;vrX9e>tbck(_R<GKV+;*X$jlN#RHUiiMXGE#-@7l^D`P>Qi
ziA&3W0&RXRN~JBohZx8BKj;k(&wu@4@5KLykTX1G-gB!Q_8PZK052=9@T?KCfW03Z
zmS003<_J2&zg5Cv*O;)?!VN4NiA$+xxMn`D!1^2xim;Q21qVN0?aeb)0D$6U{8tYC
z%2+-ZuX%x&0_?u{n&4lQTw$%EXGjS{w}&Nkf&`K0mw#Qt;gbWzMAtO{Tum-<A*@5B
z6h4h(n?5458=J;)Gf|ak7&eb?q0$}D4BoFXcrGM&=oxWK1LKTc!|3a9uK@==`x`v2
ym=(Hl_~Q8w5EuH7&_y633eM8j9HtOixLg-JJypJwoa7{*vit)e9!-7#8UO&24*rY)

literal 0
HcmV?d00001