[WIP]match with the new jenkins configuration

[xinredhat]

This change is to match with the new Jenkins installation, see the README.md

Summary by CodeRabbit

• Refactor
  • Jenkins pipelines now use a single labeled agent (simpler agent declaration) instead of a Kubernetes/OpenShift pod template.
• Chores
  • Removed obsolete commented XML from the Jenkins job XML builder to reduce clutter.

[coderabbitai]

Walkthrough

Removes commented Jenkins trigger XML from JenkinsXmlBuilder.buildJobXml (leaving an empty ) and replaces a Kubernetes/OpenShift Jenkinsfile agent block with a minimal agent { label 'tssc-jenkins-agent' } in Jenkinsfile modification logic.

Changes

Cohort / File(s)	Summary
Jenkins XML utilities src/api/jenkins/utils/jenkins.utils.ts	Deleted commented-out PipelineTriggersJobProperty and GitHubPushTrigger XML inside <properties>; no signature or runtime logic changes.
Jenkinsfile agent modification src/rhtap/modification/jenkinsfile.ts	Replaced detailed Kubernetes/OpenShift agent block (labels, cloud, serviceAccount, podRetention, containerTemplate, image) with agent { label 'tssc-jenkins-agent' }; agentImage remains but is no longer used in replacement content.

Sequence Diagram(s)

sequenceDiagram
    participant Editor as Code Modifier
    participant Jenkinsfile as Jenkinsfile source
    participant Output as Modified Jenkinsfile

    Note over Editor,Jenkinsfile: Agent replacement flow
    Editor->>Jenkinsfile: locate Kubernetes/OpenShift agent block
    Jenkinsfile-->>Editor: returns matched block
    Editor->>Output: write minimal agent block\nagent { label 'tssc-jenkins-agent' }
    Note right of Output: Removed dynamic pod/container configuration\nand image substitution

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Attention/extra review suggestions:

• Confirm no consumers rely on the previously-commented triggers being present in XML generation.
• Validate Jenkinsfile replacement unit tests to ensure full-block replacement (avoid partial matches) and that agentImage removal doesn't cause dead/unused-field regressions.
• Check CI/E2E fixtures that expect Kubernetes pod agent specifics or image references and update them if necessary.

Possibly related PRs

• implement github with jenkins as pipeline provider  #53 — Modifies src/rhtap/modification/jenkinsfile.ts (related Jenkinsfile modification logic).
• trigger Jenkins pipeline manually #150 — Adjusts Jenkins trigger handling in src/api/jenkins/utils/jenkins.utils.ts (related to job trigger XML).

Suggested labels

enhancement

Suggested reviewers

• chetna14manku
• rhopp

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title "[WIP]match with the new jenkins configuration" accurately reflects the changes in the pull request. The modifications directly address Jenkins configuration updates: removing outdated job property XML configurations and simplifying the Jenkinsfile agent block from a complex Kubernetes setup to a simpler label-based agent. The title correctly identifies the overarching purpose stated in the PR objectives—updating the repository to match the new Jenkins installation. While the title is somewhat broad and could be more specific about which configuration aspects changed, it remains relevant and doesn't mislead reviewers about the nature of the changes.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1d55de3 and 96c9c80.

📒 Files selected for processing (2)

• src/api/jenkins/utils/jenkins.utils.ts (0 hunks)
• src/rhtap/modification/jenkinsfile.ts (1 hunks)

💤 Files with no reviewable changes (1)

• src/api/jenkins/utils/jenkins.utils.ts

🚧 Files skipped from review as they are similar to previous changes (1)

• src/rhtap/modification/jenkinsfile.ts

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Red Hat Konflux / tssc-test-on-pull-request

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/rhtap/modification/jenkinsfile.ts (1)

24-27: Tighten the replacement block formatting

Swapping in a multi-line agent block without respecting indentation leaves the closing brace flush to column zero and adds trailing spaces on the label line. This harms Jenkinsfile readability and makes future maintenance noisy in reviews. Please keep the {/} aligned with the existing four-space indent and drop the trailing spaces, e.g. agent {\n label 'tssc-jenkins-agent'\n }.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1a867ab and 1d55de3.

📒 Files selected for processing (2)

• src/api/jenkins/utils/jenkins.utils.ts (0 hunks)
• src/rhtap/modification/jenkinsfile.ts (1 hunks)

💤 Files with no reviewable changes (1)

• src/api/jenkins/utils/jenkins.utils.ts

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Red Hat Konflux / tssc-test-on-pull-request

[konflux-ci-qe-bot]

@xinredhat: The following test has Failed, say /retest to rerun failed tests.

PipelineRun Name	Status	Rerun command	Build Log	Test Log
e2e-4.19-9qjv4	Failed	/retest	View Pipeline Log	View Test Logs

Inspecting Test Artifacts

To inspect your test artifacts, follow these steps:

1. Install ORAS (see the ORAS installation guide).
2. Download artifacts with the following commands:

mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-test-storage/rhtap-team/rhtap-cli:e2e-4.19-9qjv4

Test results analysis

<not enabled>

OCI Artifact Browser URL

<not enabled>