Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] fix: Enable scannerV4 in ACS #299

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Roming22
Copy link
Member

@Roming22 Roming22 commented Nov 5, 2024

Recommended configuration after reaching out the ACS team regarding RHTAPBUGS-1316

Copy link

openshift-ci bot commented Nov 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Roming22

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Nov 5, 2024
@Roming22
Copy link
Member Author

Roming22 commented Nov 5, 2024

/retest

1 similar comment
@xinredhat
Copy link
Member

/retest

@Roming22 Roming22 marked this pull request as draft November 8, 2024 13:33
@Roming22 Roming22 changed the title fix: Enable scannerV4 in ACS [WIP] fix: Enable scannerV4 in ACS Nov 8, 2024
Recommended configuration after reaching out the ACS team regarding RHTAPBUGS-1316.
Must not be merged before ACS has been updated to 4.6.
Copy link

sonarcloud bot commented Nov 13, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

#
# Test ACS availibility, pending https://issues.redhat.com/browse/RFE-6727
#
- name: acs-image-scan

Check warning

Code scanning / SonarCloud

Memory limits should be enforced Medium test

Specify a memory limit for this container. See more on SonarQube Cloud
#
# Test ACS availibility, pending https://issues.redhat.com/browse/RFE-6727
#
- name: acs-image-scan

Check warning

Code scanning / SonarCloud

Storage limits should be enforced Medium test

Specify a storage limit for this container. See more on SonarQube Cloud
@konflux-ci-qe-bot
Copy link

@Roming22: The following test has Failed, say /retest to rerun failed tests.

PipelineRun Name Status Rerun command Build Log Test Log
rhtap-cli-e2e-9qltd Failed /retest View Pipeline Log View Test Logs

Inspecting Test Artifacts

To inspect your test artifacts, follow these steps:

  1. Install ORAS (see the ORAS installation guide).
  2. Download artifacts with the following commands:
mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-test-storage/rhtap-team/rhtap-cli:rhtap-cli-e2e-9qltd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants