Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have File inherit from GenericBinary #491

Open
whyitfor opened this issue Aug 20, 2024 · 0 comments
Open

Have File inherit from GenericBinary #491

whyitfor opened this issue Aug 20, 2024 · 0 comments
Assignees

Comments

@whyitfor
Copy link
Contributor

whyitfor commented Aug 20, 2024

While reviewing #469, I noticed that most Identifiers target File and GenericBinary. The impact of this is that OFRAK tries to run identifiers twice against any File: first it runs identifiers since it is a File, then re-runs the identifier when the GenericBinary tag is added.

Since all files are binaries (by definition), it seems reasonable to refactor File as such:

class File(GenericBinary, FilesystemEntry)

and have identifiers only target GenericBinary

Which files would be affected?
Identifiers, and File.

Does the proposed maintenance include non-doc string functional changes to the Python code?
Perhaps

Are you interested in implementing it yourself?
Yes

@whyitfor whyitfor self-assigned this Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant