About.php and Dynamically Generated Menu

[rcass]

In about.php I noticed that you are just hard coding the menu.

wild-spring-2018/themes/wav-theme/page-templates/about.php

Lines 13 to 22 in d8717da

	<nav>
	<ul class="aboutNavigation">
	<li><a href="#aboutJump">About Wav</a></li>
	<li><a href="#festivalJump">Festival</a></li>
	<li><a href="#teamJump">Team</a></li>
	<li><a href="#collaboratorsJump">Collaborators</a></li>
	<li><a href="#workJump">Work</a></li>
	<li><a href="#pressJump">Press</a></li>
	</ul>
	</nav>

This might be a good interm solution, but if the client ever wants to change the menu, they will need to go into the php :/

Is there a reason for not dynamically generating the menu here? 🤔

[pinaska]

This about-page-only menu is only used for navigation through this page sections. It does not contain external links.

[rcass]

Oh I see. Okay in that case I would still create (register in functions.php) a new menu, so the client has access to this menu and can make changes.

Then under the menu items just create custom links. As a custom link to can chose the link label (ex: Press) and also the link (ex: set it to #pressJump)

Basically even through it is just jumping to different sections on the page, it still can be a dynamically generated menu (and accessible to the client).

[pinaska]

ok, we will address this. Thank you