Merge pull request #3443 from parth-gr/autoscaler-external

autoscaler: autoscaler should move to invalid in case of external mode

Author: openshift-merge-bot[bot]

controllers/storageautoscaler/storageautoscaler_controller.go

@@ -225,30 +225,44 @@ func (r *StorageAutoscalerReconciler) updateStatus(ctx context.Context, storageA
 }
 
 func (r *StorageAutoscalerReconciler) detectInvalidState(ctx context.Context, storageAutoScaler *ocsv1.StorageAutoScaler, storageCluster *ocsv1.StorageCluster, namespace string) (bool, error) {
+	// check if it's a external mode storage cluster
+	externalMode, err := r.detectExternalModeStorageCluster(ctx, storageCluster, storageAutoScaler)
+	if err != nil {
+		return false, err
+	}
+	if externalMode {
+		return true, nil
+	}
+
 	// if more than one storage autoscaler is present in the cluster with same device class and same storage cluster
 	// return error
 	duplicateCr, err := r.detectDuplicateStorageAutoScaler(ctx, storageAutoScaler, namespace)
 	if err != nil {
 		return false, err
 	}
+	if duplicateCr {
+		return true, nil
+	}
 
 	// list the storagecluster deviceset storageclass
 	duplicateClass, err := r.detectLsoStorageclass(ctx, storageCluster, storageAutoScaler)
 	if err != nil {
 		return false, err
 	}
+	if duplicateClass {
+		return true, nil
+	}
 
 	// check if the storage profile is lean
 	leanProfile, err := r.detectLeanResourceProfile(ctx, storageCluster, storageAutoScaler)
 	if err != nil {
 		return false, err
 	}
-
-	if duplicateCr || duplicateClass || leanProfile {
-		r.Log.Info("storage autoscaler is in invalid state", "namespace", storageAutoScaler.Namespace, "name", storageAutoScaler.Name)
+	if leanProfile {
 		return true, nil
 	}
 
+	r.Log.Info("storage autoscaler is in invalid state", "namespace", storageAutoScaler.Namespace, "name", storageAutoScaler.Name)
 	return false, nil
 }
 
@@ -337,6 +351,27 @@ func (r *StorageAutoscalerReconciler) detectLeanResourceProfile(ctx context.Cont
 	return true, nil
 }
 
+func (r *StorageAutoscalerReconciler) detectExternalModeStorageCluster(ctx context.Context, storageCluster *ocsv1.StorageCluster, storageAutoScaler *ocsv1.StorageAutoScaler) (bool, error) {
+	if !storageCluster.Spec.ExternalStorage.Enable {
+		return false, nil
+	}
+
+	err := fmt.Errorf("storage cluster is in external mode, autoscaler does not support external mode, delete the autoStorageScaler cr as scaling is not supported")
+	r.Log.Error(err, "storage cluster is external mode")
+
+	storageAutoScaler.Status.Phase = ocsv1.StorageAutoScalerPhaseInvalid
+	storageAutoScaler.Status.Error = &ocsv1.TimestampedError{
+		Message:   "storage cluster is in external mode, autoscaler does not support external mode, delete the autoStorageScaler cr as scaling is not supported",
+		Timestamp: metav1.Now(),
+	}
+	err = r.updateStatus(ctx, storageAutoScaler)
+	if err != nil {
+		return false, err
+	}
+	// not sending an error as user can see in the cr status
+	return true, nil
+}
+
 func (r *StorageAutoscalerReconciler) getCurrentOsdSizeAndCount(ctx context.Context, storageAutoScaler *ocsv1.StorageAutoScaler) (resource.Quantity, int, error) {
 	currentOsdCount := 0
 	currentOsdSize := resource.Quantity{}