-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Symfony62] Replace Sensio Security #393
Comments
Yes, this will need a custom rule, to handle the expressions. |
It will be more complex :(
|
Well its good to have these 2 cases in testfixure |
@wkania
with
|
@pepeh
Rector could skip everything with "dot", "or" and "and". Those cases are probably to complex to be refactored automatically or with easy set of conditions. |
Looking into this... |
I've kicked off a rule to handle this: #622 Give it a try and let me know, what are the missed cases 🙏 Thanks |
I tested it and it's a good start. Most code refactored correctly. Changed Changed Changed Changed Thx @TomasVotruba |
Thanks for testing 👍 Could you share these in form of diffs? I'd check how to add support for them |
|
Also variables should be in subject.
|
Thanks, I'll look into it 👍 |
See #640 |
sensio-framework-extra-bundle is abandoned.
Some attributes have been implemented in Symfony 6.2 and Rector can already refactor code for them.
But,
Security
attribute will not be implemented in Symfony.From what I know about Rector we can't currently make change from:
to:
This require a new rule, something custom like this?
The text was updated successfully, but these errors were encountered: