Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events: workflow when triggering show/hide events and follows a link #271

Open
humitos opened this issue Mar 6, 2024 · 0 comments
Open
Labels
Needed: design decision A core team decision is required

Comments

@humitos
Copy link
Member

humitos commented Mar 6, 2024

While working on #268, Anthony found this use case wouldn't work:

if anyone tries to do anything async from the SEARCH_HIDE event, the code will likely be cut off. The operation order can be something like:

  • User clicks results
  • Event SEARCH_HIDE is fired off
  • Browser navigates to link href
  • Event SEARCH_HIDE is never consumed, or async code like fetch never finishes.

The user doesn't have the ability to affect the event propagation, so the browser will always follow the link.

I'm not sure what's the solution here, but I'm opening this issue to have a place to track this conversation.

Reference: #268 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needed: design decision A core team decision is required
Projects
None yet
Development

No branches or pull requests

1 participant