Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sandhi - Editing #192

Open
IanMcCrabb opened this issue Jan 5, 2021 · 4 comments
Open

Sandhi - Editing #192

IanMcCrabb opened this issue Jan 5, 2021 · 4 comments

Comments

@IanMcCrabb
Copy link
Collaborator

Have an issue with modifying sandhi, No problem with implementing sandhi across a token boundary but when one atempts to edit that sandhi decompostion, from either of the tokens, nothing happens. Can confirm that both tokens are owned by the editor.

e.g, ceva

c
e(a e)

e(a e)
va

@stevewh
Copy link
Collaborator

stevewh commented Jan 31, 2021

There is another issue from Nepali text project. Seems that somehow a regular expression was changed. Also there were some issues with the sandhi UI in the property window. Both are now fixed.

@stevewh stevewh added the Test label Jan 31, 2021
@stevewh stevewh assigned andrea103 and unassigned stevewh Jan 31, 2021
@stevewh
Copy link
Collaborator

stevewh commented Feb 3, 2021

current change does not allow compound decomposition, removal of sandhi and saves on enter but not click on save.

@IanMcCrabb IanMcCrabb removed the Test label Feb 3, 2021
@IanMcCrabb IanMcCrabb assigned stevewh and IanMcCrabb and unassigned andrea103 Feb 3, 2021
@IanMcCrabb
Copy link
Collaborator Author

happy to test when you have fixes

@stevewh
Copy link
Collaborator

stevewh commented Feb 4, 2021

Fixed the saving of compound decomposition and save button click. The removal of the sandhi is more difficult to the point that I'm unsure it ever worked. The issue is the dependency on the structure of a compound of compounds. I think that we should first prioritize the need to delete a sandhi and explicitly define what it means to remove one in a complex compound hierarchy.

The other issues are ready for testing including the change of the sandhi decomposition.

@stevewh stevewh added the Test label Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants