Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP SDK requires composer itself #987

Open
xolf opened this issue Apr 22, 2024 · 1 comment
Open

PHP SDK requires composer itself #987

xolf opened this issue Apr 22, 2024 · 1 comment
Labels
php Issues related to our PHP SDK

Comments

@xolf
Copy link
Contributor

xolf commented Apr 22, 2024

The readme/metrics requires Composer itself. As mentioned by the maintainers of Composer, see composer/composer#11940 (comment), this is a bad design and lead to unusable composer installation if the version within the vendor folder differs from the system-wide installation.

I'm not quite sure, what are the reasons to require composer/composer itself, but not other package are requiring composer, so one should be safe to remove.

@xolf xolf changed the title PHP SDK requires composer itself fix: PHP SDK requires composer itself Apr 22, 2024
@Seldaek
Copy link

Seldaek commented Apr 22, 2024

I guess it might have been a misunderstanding that this is needed for InstalledVersions to work. But that's just always available when the composer-runtime-api requirement is fullfilled so it should be fine. Removing the require on composer/composer definitely would be good.

@erunion erunion added the php Issues related to our PHP SDK label Jul 26, 2024
@erunion erunion changed the title fix: PHP SDK requires composer itself PHP SDK requires composer itself Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
php Issues related to our PHP SDK
Projects
None yet
Development

No branches or pull requests

3 participants