Swift Concurrency

[domkm]

Many of the types in swift-toolkit are stateless structs and are therefore inherently Sendable but Swift does not infer this, leading to warnings or the need to use @preconcurrency import Readium.... For example, Locator, Publication.Profile, Manifest, Metadata, Link, and perhaps many other structs, are immutable but are not marked Sendable. What do you think of adding Sendable conformance as much as possible to obviate the need for @preconcurrency?

[mickael-menu]

Sure that makes perfect sense. Are you interested in contributing a PR for this?

[domkm]

Sure, can do.

Is there a deadline for when you're hoping to release 3.0.0 or just continue updating until you feel it's ready?

[mickael-menu]

Thanks! Yes the final release is planned for end of June. I'm currently working on converting some completion based APIs to async variants.

[domkm]

Sounds good.

Will Streamer.open be included in your conversion?

It's probably a ton of work but it'd also be fantastic if all of the Publication creation process could be async since that would enable the use of newer non-blocking APIs (such as those we wanted to use in my recent AudioParser metadata PR).

If you haven't already, may I suggest setting strict concurrency checking to "complete"? It found tons of subtle concurrency issues in my codebase.

[mickael-menu]

Will Streamer.open be included in your conversion?

Yes I'll try to get it async as well.

If you haven't already, may I suggest setting strict concurrency checking to "complete"? It found tons of subtle concurrency issues in my codebase.

Thanks, I will take a look.

[mickael-menu]

By the way I enabled strict concurrency checks in this branch: https://github.com/readium/swift-toolkit/tree/strict-concurrency

I'm not merging it yet as there's a lot of warnings, but you can use it if you need for the @Sendable work.