Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PrematureCloseException root exception is not logged in netty5 branch. #2938

Open
pderop opened this issue Oct 18, 2023 · 0 comments
Open

PrematureCloseException root exception is not logged in netty5 branch. #2938

pderop opened this issue Oct 18, 2023 · 0 comments
Labels
type/enhancement A general enhancement
Milestone

Comments

@pderop
Copy link
Contributor

pderop commented Oct 18, 2023

The PR #2937 that has been merged into the netty5 branch is not operational (only in netty5 branch).
It needs to be completed with another PR, and for the moment, the HttpServerTests.testIssue2927_H2C and HttpServerTests.testIssue2927 tests are disabled (in netty5 branch).

The problem in netty5 is that when the HeaderListSizeException is thrown, then:

  1. First, the HttpClientOperations.onInboundClose() is invoked -> here, no unprocessedOutboundError, so the PrematureCloseException is logged without the root cause exception.
  2. And right after, the ChannelOperations.onError(Throwable t) method is called .. but this too late, because the HttpClientOperations.onInboundClose() method has already logged the PrematureCloseExeption without the HeaderListSizeException root cause exception.

Expected Behavior

HttpServerTests.testIssue2927_H2C and HttpServerTests.testIssue2927 are not passing in netty5 branch, and they are currently disabled.

Actual Behavior

The HttpClientOperations.onInboundClose() is invoked before the ChannelOperations.onError(Throwable t) , so we log the PrematureCloseException without the HeaderListSizeException root cause exception

Steps to Reproduce

Possible Solution

Your Environment

@pderop pderop added type/bug A general bug status/need-triage A new issue that still need to be evaluated as a whole labels Oct 18, 2023
@pderop pderop added this to the 2.0.0-M4 milestone Oct 18, 2023
@violetagg violetagg added type/enhancement A general enhancement and removed status/need-triage A new issue that still need to be evaluated as a whole type/bug A general bug labels Oct 19, 2023
@violetagg violetagg modified the milestones: 2.0.0-M4, 2.0.x Backlog Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants