perf: optimize package lookup from O(N*M) to O(N+M) using Map (#60)

sunnylqm · google-labs-jules[bot] · web-flow · commit 434d6e47ee9d · 2026-06-27T21:11:50.000+08:00
Co-authored-by: google-labs-jules[bot] &lt;161369871+google-labs-jules[bot]@users.noreply.github.com&gt;
Co-authored-by: sunnylqm &lt;615282+sunnylqm@users.noreply.github.com&gt;
diff --git a/src/package.ts b/src/package.ts
@@ -375,10 +375,10 @@ export const packageCommands = {
         throw new Error(t('noPackagesFound', { appId }));
       }
 
+      const allPkgsMap = new Map(allPkgs.map((pkg) => [pkg.name, pkg]));
+
       packageIds = packageVersions.map((packageVersion) => {
-        const selectedPackage = allPkgs.find(
-          (pkg) => pkg.name === packageVersion,
-        );
+        const selectedPackage = allPkgsMap.get(packageVersion);
         if (!selectedPackage) {
           throw new Error(t('packageNotFound', { packageVersion }));
         }

Original file line number	Diff line number	Diff line change
`@@ -375,10 +375,10 @@ export const packageCommands = {`
`375`	`375`	`throw new Error(t('noPackagesFound', { appId }));`
`376`	`376`	`}`
`377`	`377`
	`378`	`+ const allPkgsMap = new Map(allPkgs.map((pkg) => [pkg.name, pkg]));`
	`379`	`+`
`378`	`380`	`packageIds = packageVersions.map((packageVersion) => {`
`379`		`- const selectedPackage = allPkgs.find(`
`380`		`- (pkg) => pkg.name === packageVersion,`
`381`		`- );`
	`381`	`+ const selectedPackage = allPkgsMap.get(packageVersion);`
`382`	`382`	`if (!selectedPackage) {`
`383`	`383`	`throw new Error(t('packageNotFound', { packageVersion }));`
`384`	`384`	`}`