fix: parser correctness, API pagination, sourcemap exclusion, misc cleanups

- binary.ts: versionName scrub now only strips UTF-16 NUL padding (was
  deleting spaces and all non-ASCII chars, e.g. Chinese version names);
  readDimension complexToFloat uses the raw value for unit extraction
- zip.ts: regex entry matching also tests the original (case-preserved)
  entry name, fixing AAB manifest lookup that never matched
- check-lockfile.ts: recognize pnpm-workspace.yaml as monorepo root
- api.ts: getAllPackages pages through results (server caps limit at 100);
  query() throws on 200-with-non-JSON body instead of returning undefined
- bundle-runner.ts: harmony Sentry properties, spawn error listener,
  close-callback error propagation, compose-source-maps resolution
- bundle-pack.ts: derive sourcemap exclusion from actual bundleName;
  drop dead '.'/'..' entries
- app.ts: deleteApp returns after cancel instead of deleting /app/undefined
- http-helper.ts: clear ping timeout so the process isn't held alive ~5s
- provider.ts: listPackages requires appId
- utils/index.ts: guard NaN buildTime; close zip fd on read errors
- .gitignore: fix broken '.pushytest-output/' line (now ignores .pushy and
  test-output*/), drop personal bench entries; remove pr.md, .prettierrc.json

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Author: sunnylqm

.gitignore

@@ -107,10 +107,5 @@ lib/
 .DS_Store
 # react-native-update
 .update
-.pushytest-output/
-test-output2/
-bench.ts
-bench2.ts
-test-output3/
-test-output4/
-bench-node.js
+.pushy
+test-output*/

.prettierrc.json

@@ -140,9 +140,13 @@ async function query(url: string, options: RuntimeRequestInit) {
   try {
     json = JSON.parse(text);
   } catch (_e) {
-    if (resp.status === 200 && text) {
-      console.warn(
-        `Warning: API returned 200 with non-JSON body (${text.length} bytes)`,
+    if (resp.status === 200) {
+      // a proxy/gateway likely replaced the response; surface it instead of
+      // returning undefined and crashing callers on destructuring
+      throw createRequestError(
+        `API returned 200 with non-JSON body (${text.length} bytes)`,
+        fullUrl,
+        resp.status,
       );
     }
   }
@@ -282,6 +286,27 @@ export async function uploadFile(fn: string, key?: string) {
 }
 
 export const getAllPackages = async (appId: string) => {
-  const { data } = await get(`/app/${appId}/package/list?limit=1000`);
-  return data as Package[] | undefined | null;
+  // the server caps limit at 100, so page through with offset
+  const limit = 100;
+  let offset = 0;
+  let allPackages: Package[] | undefined | null;
+  while (true) {
+    const { data, count } = await get(
+      `/app/${appId}/package/list?offset=${offset}&limit=${limit}`,
+    );
+    const packages = data as Package[] | undefined | null;
+    if (allPackages === undefined || allPackages === null) {
+      allPackages = packages;
+    } else if (packages) {
+      allPackages.push(...packages);
+    }
+    if (!packages || packages.length === 0) {
+      break;
+    }
+    offset += packages.length;
+    if (offset >= Number(count || 0)) {
+      break;
+    }
+  }
+  return allPackages;
 };

pr.md

@@ -147,6 +147,7 @@ export function getAppCommands() {
       const id = args[0] || (await chooseApp(platform)).id;
       if (!id) {
         console.log(t('cancelled'));
+        return;
       }
       await doDelete(`/app/${id}`);
       console.log(t('operationSuccess'));

src/api.ts

@@ -4,15 +4,20 @@ import { ZipFile as YazlZipFile } from 'yazl';
 import { t } from './utils/i18n';
 import { zipOptionsForPayloadFile } from './utils/zip-options';
 
-const ignorePackingFileNames = [
-  '.',
-  '..',
-  'index.bundlejs.map',
-  'bundle.harmony.js.map',
-];
 const ignorePackingExtensions = ['DS_Store', 'txt.map'];
 
-export async function packBundle(dir: string, output: string): Promise<void> {
+export async function packBundle(
+  dir: string,
+  output: string,
+  bundleName?: string,
+): Promise<void> {
+  const ignorePackingFileNames = [
+    'index.bundlejs.map',
+    'bundle.harmony.js.map',
+  ];
+  if (bundleName) {
+    ignorePackingFileNames.push(`${bundleName}.map`);
+  }
   console.log(t('packing'));
   fs.ensureDirSync(path.dirname(output));
   await new Promise<void>((resolve, reject) => {

src/app.ts

@@ -241,6 +241,11 @@ export async function runReactNativeBundleCommand({
       process.env.SENTRY_PROPERTIES = 'ios/sentry.properties';
     } else if (platform === 'android') {
       process.env.SENTRY_PROPERTIES = 'android/sentry.properties';
+    } else if (
+      platform === 'harmony' &&
+      fs.existsSync('harmony/sentry.properties')
+    ) {
+      process.env.SENTRY_PROPERTIES = 'harmony/sentry.properties';
     }
   }
 
@@ -302,20 +307,24 @@ export async function runReactNativeBundleCommand({
       console.error(data.toString().trim());
     });
 
+    reactNativeBundleProcess.once('error', reject);
+
     reactNativeBundleProcess.on('close', async (exitCode) => {
       if (exitCode) {
         reject(new Error(t('bundleCommandError', { code: exitCode })));
         return;
       }
 
-      let hermesEnabled: boolean | undefined = false;
+      try {
+        let hermesEnabled: boolean | undefined = false;
 
-      if (forceHermes) {
-        hermesEnabled = true;
-        console.log(t('forceHermes'));
-      } else if (platform === 'android') {
-        const gradleProperties = await new Promise<{ hermesEnabled?: boolean }>(
-          (resolve) => {
+        if (forceHermes) {
+          hermesEnabled = true;
+          console.log(t('forceHermes'));
+        } else if (platform === 'android') {
+          const gradleProperties = await new Promise<{
+            hermesEnabled?: boolean;
+          }>((resolve) => {
             properties.parse(
               './android/gradle.properties',
               { path: true },
@@ -331,42 +340,48 @@ export async function runReactNativeBundleCommand({
                 resolve(props);
               },
             );
-          },
-        );
-        hermesEnabled = gradleProperties.hermesEnabled;
+          });
+          hermesEnabled = gradleProperties.hermesEnabled;
+
+          if (typeof hermesEnabled !== 'boolean') {
+            hermesEnabled = gradleConfig.enableHermes;
+          }
+        } else if (
+          platform === 'ios' &&
+          fs.existsSync('ios/Pods/hermes-engine')
+        ) {
+          hermesEnabled = true;
+        }
 
-        if (typeof hermesEnabled !== 'boolean') {
-          hermesEnabled = gradleConfig.enableHermes;
+        if (hermesEnabled) {
+          await compileHermesByteCode(
+            bundleName,
+            outputFolder,
+            sourcemapOutput,
+            !isSentry,
+          );
         }
-      } else if (
-        platform === 'ios' &&
-        fs.existsSync('ios/Pods/hermes-engine')
-      ) {
-        hermesEnabled = true;
-      }
 
-      if (hermesEnabled) {
-        await compileHermesByteCode(
-          bundleName,
-          outputFolder,
-          sourcemapOutput,
-          !isSentry,
-        );
-      }
+        if (platform === 'harmony') {
+          const harmonyRawAssetsPath =
+            'harmony/entry/src/main/resources/rawfile/assets';
+          fs.ensureDirSync(harmonyRawAssetsPath);
+          fs.copySync(outputFolder, harmonyRawAssetsPath, {
+            overwrite: true,
+            // sourcemaps must not ship inside the native package
+            filter: (src) => !src.endsWith('.map'),
+          });
+          fs.moveSync(
+            `${harmonyRawAssetsPath}/bundle.harmony.js`,
+            `${harmonyRawAssetsPath}/../bundle.harmony.js`,
+            { overwrite: true },
+          );
+        }
 
-      if (platform === 'harmony') {
-        const harmonyRawAssetsPath =
-          'harmony/entry/src/main/resources/rawfile/assets';
-        fs.ensureDirSync(harmonyRawAssetsPath);
-        fs.copySync(outputFolder, harmonyRawAssetsPath, { overwrite: true });
-        fs.moveSync(
-          `${harmonyRawAssetsPath}/bundle.harmony.js`,
-          `${harmonyRawAssetsPath}/../bundle.harmony.js`,
-          { overwrite: true },
-        );
+        resolve();
+      } catch (error) {
+        reject(error);
       }
-
-      resolve();
     });
   });
 }
@@ -529,9 +544,15 @@ async function compileHermesByteCode(
     hermesCommand,
   );
   if (sourcemapOutput) {
-    const composerPath =
-      'node_modules/react-native/scripts/compose-source-maps.js';
-    if (!fs.existsSync(composerPath)) {
+    let composerPath: string;
+    try {
+      // resolve through the project so hoisted node_modules (monorepos) work
+      composerPath = require.resolve(
+        'react-native/scripts/compose-source-maps.js',
+        { paths: [process.cwd()] },
+      );
+    } catch {
+      console.warn(t('composeSourceMapsNotFound'));
       return;
     }
     console.log(t('composingSourceMap'));
@@ -571,7 +592,7 @@ export async function copyDebugidForSentry(
         },
       );
     } catch {
-      console.error(t('sentryCliNotFound'));
+      console.error(t('sentryReactNativeNotFound'));
       return;
     }
 

src/bundle-pack.ts

@@ -75,11 +75,12 @@ function normalizeBundleOptions(
   platform: string,
 ): NormalizedBundleOptions {
   return {
-    bundleName: getStringOption(
-      translatedOptions,
-      'bundleName',
-      'index.bundlejs',
-    ),
+    // harmony bundles always use this fixed name (runReactNativeBundleCommand
+    // forces it), so sourcemap paths and Sentry uploads must match
+    bundleName:
+      platform === 'harmony'
+        ? 'bundle.harmony.js'
+        : getStringOption(translatedOptions, 'bundleName', 'index.bundlejs'),
     entryFile: getStringOption(translatedOptions, 'entryFile', 'index.js'),
     intermediaDir: getStringOption(
       translatedOptions,
@@ -222,7 +223,11 @@ export const bundleCommands = {
       isSentry: bundleParams.sentry,
     });
 
-    await packBundle(path.resolve(normalized.intermediaDir), realOutput);
+    await packBundle(
+      path.resolve(normalized.intermediaDir),
+      realOutput,
+      normalized.bundleName,
+    );
 
     if (normalized.name) {
       await publishBundleVersion(realOutput, platform, {

src/bundle-runner.ts

@@ -132,6 +132,8 @@ This can reduce the risk of inconsistent dependencies and supply chain attacks.
     'Set {{rollout}}% rollout for OTA update {{version}} on native version(s) {{versions}}',
   rolloutRangeError: 'rollout must be an integer between 1-100',
   runningHermesc: 'Running hermesc: {{- command}} {{- args}}',
+  sentryReactNativeNotFound:
+    'Cannot find @sentry/react-native, please make sure it is properly installed',
   sentryCliNotFound:
     'Cannot find Sentry CLI tool, please make sure @sentry/cli is properly installed',
   sentryReleaseCreated: 'Sentry release created for version: {{version}}',
@@ -182,6 +184,8 @@ This can reduce the risk of inconsistent dependencies and supply chain attacks.
   nodeHdiffpatchRequired:
     'This function needs "node-hdiffpatch". Please run "{{scriptName}} install node-hdiffpatch" to install',
   apkExtracted: 'APK extracted to {{output}}',
+  composeSourceMapsNotFound:
+    'Cannot find react-native/scripts/compose-source-maps.js, skipping hermes sourcemap composing. The uploaded sourcemap may not match the compiled bundle.',
   installPackageRequired:
     'Please specify the package to install, e.g. "{{scriptName}} install node-hdiffpatch"',
   installFailed: 'Failed to install {{packages}}: {{error}}',

src/bundle.ts

@@ -123,6 +123,7 @@ export default {
     '已在原生版本 {{versions}} 上设置灰度发布 {{rollout}}% 热更包 {{version}}',
   rolloutRangeError: 'rollout 必须是 1-100 的整数',
   runningHermesc: '运行 hermesc：{{- command}} {{- args}}',
+  sentryReactNativeNotFound: '无法找到 @sentry/react-native，请确保已正确安装',
   sentryCliNotFound: '无法找到 Sentry CLI 工具，请确保已正确安装 @sentry/cli',
   sentryReleaseCreated: '已为版本 {{version}} 创建 Sentry release',
   totalApps: '共 {{count}} 个 {{platform}} 应用',
@@ -168,6 +169,8 @@ export default {
   nodeHdiffpatchRequired:
     '此功能需要 "node-hdiffpatch"。请运行 "{{scriptName}} install node-hdiffpatch" 来安装',
   apkExtracted: 'APK 已提取到 {{output}}',
+  composeSourceMapsNotFound:
+    '找不到 react-native/scripts/compose-source-maps.js，跳过 hermes sourcemap 合成。上传的 sourcemap 可能与编译后的 bundle 不匹配。',
   installPackageRequired:
     '请指定要安装的包，例如 "{{scriptName}} install node-hdiffpatch"',
   installFailed: '安装 {{packages}} 失败: {{error}}',