-
Notifications
You must be signed in to change notification settings - Fork 808
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Use create-react-class to avoid React.createClass deprecations
fixes #367
- Loading branch information
1 parent
16efd72
commit 86987d5
Showing
4 changed files
with
17 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1087,6 +1087,13 @@ core-util-is@~1.0.0: | |
version "1.0.2" | ||
resolved "https://registry.yarnpkg.com/core-util-is/-/core-util-is-1.0.2.tgz#b5fd54220aa2bc5ab57aab7140c940754503c1a7" | ||
|
||
create-react-class@^15.5.2: | ||
version "15.5.2" | ||
resolved "https://registry.yarnpkg.com/create-react-class/-/create-react-class-15.5.2.tgz#6a8758348df660b88326a0e764d569f274aad681" | ||
dependencies: | ||
fbjs "^0.8.9" | ||
object-assign "^4.1.1" | ||
|
||
cross-spawn@^4.0.0: | ||
version "4.0.2" | ||
resolved "https://registry.yarnpkg.com/cross-spawn/-/cross-spawn-4.0.2.tgz#7b9247621c23adfdd3856004a823cbe397424d41" | ||
|
@@ -1563,19 +1570,7 @@ [email protected]: | |
version "0.1.8" | ||
resolved "https://registry.yarnpkg.com/eyes/-/eyes-0.1.8.tgz#62cf120234c683785d902348a800ef3e0cc20bc0" | ||
|
||
fbjs@^0.8.1, fbjs@^0.8.4: | ||
version "0.8.8" | ||
resolved "https://registry.yarnpkg.com/fbjs/-/fbjs-0.8.8.tgz#02f1b6e0ea0d46c24e0b51a2d24df069563a5ad6" | ||
dependencies: | ||
core-js "^1.0.0" | ||
isomorphic-fetch "^2.1.1" | ||
loose-envify "^1.0.0" | ||
object-assign "^4.1.0" | ||
promise "^7.1.1" | ||
setimmediate "^1.0.5" | ||
ua-parser-js "^0.7.9" | ||
|
||
fbjs@^0.8.9: | ||
fbjs@^0.8.1, fbjs@^0.8.4, fbjs@^0.8.9: | ||
version "0.8.12" | ||
resolved "https://registry.yarnpkg.com/fbjs/-/fbjs-0.8.12.tgz#10b5d92f76d45575fd63a217d4ea02bea2f8ed04" | ||
dependencies: | ||
|
@@ -3202,6 +3197,10 @@ object-assign@^4.0.1, object-assign@^4.1.0: | |
version "4.1.0" | ||
resolved "https://registry.yarnpkg.com/object-assign/-/object-assign-4.1.0.tgz#7a3b3d0e98063d43f4c03f2e8ae6cd51a86883a0" | ||
|
||
object-assign@^4.1.1: | ||
version "4.1.1" | ||
resolved "https://registry.yarnpkg.com/object-assign/-/object-assign-4.1.1.tgz#2109adc7965887cfc05cbbd442cac8bfbb360863" | ||
|
||
[email protected]: | ||
version "0.0.3" | ||
resolved "https://registry.yarnpkg.com/object-component/-/object-component-0.0.3.tgz#f0c69aa50efc95b866c186f400a33769cb2f1291" | ||
|
86987d5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@claydiffrient what the point of using
create-react-class
?Why not to refactor to ES6 classes and
extend
?86987d5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
86987d5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@claydiffrient got it, thanks