Fix Cxx WebSocket write queue state - #58201
Closed
OskarEichler wants to merge 1 commit into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
the
Shared with Meta
|
@javache has imported this pull request. If you are a Meta employee, you can view this in D118266757. |
cortinico
approved these changes
Sep 1, 2026
cortinico
left a comment
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
shashikant-panchal
pushed a commit
to shashikant-panchal/react-native
that referenced
this pull request
Sep 10, 2026
Summary: The Cxx WebSocket client can write before its handshake, drop queued pre-connect and empty frames, allow concurrent Beast writes through a check-then-set race, and retain writer ownership after errors. Gate draining on a successful connection, atomically claim the single writer, preserve empty frames, and release state on every completion. Fixes react#58200. ## Changelog: [GENERAL] [FIXED] - Preserve buffered and empty Cxx WebSocket frames and serialize writes. Pull Request resolved: react#58201 Test Plan: - Exact temporary localhost Boost server harness on untouched main: `Operation canceled`, both expected frames missing, exit 1. - Fixed source harness: received the pre-connect buffered payload and empty frame, exit 0. - Actual source and harness compiled under C++20 with `-Wall -Werror`; only a local third-party Boost/Clang deprecation was demoted. - Repository clang-format and `git diff --check` passed. - Temporary harness/build wiring was removed; this PR contains one runtime file only. No UI change; screenshots are not applicable. Reviewed By: cortinico Differential Revision: D118266757 Pulled By: javache fbshipit-source-id: 2881893bdcb4c6873087e5cd821a82af76e8bbb8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The Cxx WebSocket client can write before its handshake, drop queued pre-connect and empty frames, allow concurrent Beast writes through a check-then-set race, and retain writer ownership after errors. Gate draining on a successful connection, atomically claim the single writer, preserve empty frames, and release state on every completion.
Fixes #58200.
Changelog:
[GENERAL] [FIXED] - Preserve buffered and empty Cxx WebSocket frames and serialize writes.
Test Plan:
Operation canceled, both expected frames missing, exit 1.-Wall -Werror; only a local third-party Boost/Clang deprecation was demoted.git diff --checkpassed.No UI change; screenshots are not applicable.