Cover nativemodule/cputime with guards (#58142) - #58142
Closed
j-piasecki wants to merge 1 commit into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D117340507. |
meta-codesync
Bot
changed the title
nativemodule/cputime with guardsnativemodule/cputime with guards (#58142)
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Aug 28, 2026
Summary: Classifies `react/nativemodule/cputime:cputime` as a private target under the C++ stable API three-tier visibility model. Adds `#include <react/cxxstableapi/PrivateGuard.h>` to both of the module's exported headers (`CPUTime.h` and `NativeCPUTime.h`), and wires the guard dependency into BUCK and CMake. No pod ships this module and it is not exported through prefab, so there is no podspec or SwiftPM change to make. The guards are inert unless a consumer defines `RN_STRICT_API`, so there is no behavior change. Changelog: [Internal] Differential Revision: D117340507
j-piasecki
force-pushed
the
export-D117340507
branch
from
August 28, 2026 08:11
2ad242a to
170d6f4
Compare
cortinico
approved these changes
Sep 1, 2026
cortinico
left a comment
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
j-piasecki
force-pushed
the
export-D117340507
branch
from
September 2, 2026 07:10
170d6f4 to
8027446
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 2, 2026
Summary: Classifies `react/nativemodule/cputime:cputime` as a private target under the C++ stable API three-tier visibility model. Adds `#include <react/cxxstableapi/PrivateGuard.h>` to both of the module's exported headers (`CPUTime.h` and `NativeCPUTime.h`), and wires the guard dependency into BUCK and CMake. No pod ships this module and it is not exported through prefab, so there is no podspec or SwiftPM change to make. The guards are inert unless a consumer defines `RN_STRICT_API`, so there is no behavior change. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D117340507
Summary: Classifies `react/nativemodule/cputime:cputime` as a private target under the C++ stable API three-tier visibility model. Adds `#include <react/cxxstableapi/PrivateGuard.h>` to both of the module's exported headers (`CPUTime.h` and `NativeCPUTime.h`), and wires the guard dependency into BUCK and CMake. No pod ships this module and it is not exported through prefab, so there is no podspec or SwiftPM change to make. The guards are inert unless a consumer defines `RN_STRICT_API`, so there is no behavior change. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D117340507
j-piasecki
force-pushed
the
export-D117340507
branch
from
September 2, 2026 07:12
8027446 to
6b31d2c
Compare
|
This pull request has been merged in e54aea4. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Classifies
react/nativemodule/cputime:cputimeas a private target under the C++ stable API three-tier visibility model. Adds#include <react/cxxstableapi/PrivateGuard.h>to both of the module's exported headers (CPUTime.handNativeCPUTime.h), and wires the guard dependency into BUCK and CMake.No pod ships this module and it is not exported through prefab, so there is no podspec or SwiftPM change to make.
The guards are inert unless a consumer defines
RN_STRICT_API, so there is no behavior change.Changelog: [Internal]
Reviewed By: cortinico
Differential Revision: D117340507