Support 'react-native/react-private-interface' in build-types - #58075
Closed
huntie wants to merge 1 commit into
Closed
Support 'react-native/react-private-interface' in build-types#58075huntie wants to merge 1 commit into
huntie wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
cursor
Bot
force-pushed
the
cursor/fix-js-api-exports-resolution-db59
branch
from
August 22, 2026 19:07
9ee6f05 to
d243be5
Compare
huntie
changed the title
huntie
changed the title
cursor
Bot
force-pushed
the
cursor/fix-js-api-exports-resolution-db59
branch
from
August 22, 2026 19:52
d243be5 to
2b77af6
Compare
huntie
force-pushed
the
cursor/fix-js-api-exports-resolution-db59
branch
from
August 24, 2026 15:46
2b77af6 to
4f29a52
Compare
huntie
changed the title
huntie
marked this pull request as ready for review
August 24, 2026 15:55
facebook-github-tools
Bot
added
the
Shared with Meta
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this in D117513265. |
|
@cortinico merged this pull request in cec189b. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Minimum infra fix to enable subsequently landing #57940.
Referencing
ReactNativeFeatureFlagson the existingreact-native/react-private-interfaceboundary is blocked by a gap in thebuild-typespipeline and a type translation error, addressed here.Changes
simpleResolve.js: Explicitly supportreact-native/react-private-interfaceas a special case, fixing resolution.ReactNativeFeatureFlagsBase.js: Tweak theOverridesFortype here to fix TypeScript translation compatibility, where the unconstrainedTtype param is now narrowed.Impact
No change to the API snapshot (the
ReactNativeFeatureFlagsimport is ultimately tree-shaken!), and no effect on generated types until #57940 lands.Changelog: [Internal]
Test Plan
yarn build-typestypes_generated/**/featureflags/**