: Add IWorkerSetup runtime plumbing - #57801
Open
tmikov wants to merge 1 commit into
Open
Conversation
Summary: X-link: facebook/hermes#2123 Add IWorkerSetup and ISetWorkerSetup to hermes-interfaces.h (an ICast-based setter with a getWorkerSetup accessor), and wire HermesRuntimeImpl to store the integrator's opaque provider pointer and expose it via that getter. Give the APITest provider harness a virtual destructor and mark a not-yet-used helper [[maybe_unused]] so the build is warning-free. Changelog: Add IWorkerSetup Differential Revision: D114374137
meta-cla
Bot
added
the
CLA Signed
|
@tmikov has exported this pull request. If you are a Meta employee, you can view the originating Diff in D114374137. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: facebook/hermes#2123
Add IWorkerSetup and ISetWorkerSetup to
hermes-interfaces.h (an ICast-based setter with a
getWorkerSetup accessor), and wire HermesRuntimeImpl to store
the integrator's opaque provider pointer and expose it via that getter.
Give the APITest provider harness a virtual destructor and mark a
not-yet-used helper [[maybe_unused]] so the build is warning-free.
Changelog: Add IWorkerSetup
Differential Revision: D114374137