Skip to content

Remove unnecessary OSSLibraryExample - #52705

Closed
cortinico wants to merge 2 commits into
mainfrom
nc/oss-lib-cleanup
Closed

Remove unnecessary OSSLibraryExample#52705
cortinico wants to merge 2 commits into
mainfrom
nc/oss-lib-cleanup

Conversation

@cortinico

Copy link
Copy Markdown
Contributor

Summary:

This module is currently unused, so we can clean it up.

Changelog:

[INTERNAL] -

Test Plan:

CI

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 18, 2025
@facebook-github-bot

Copy link
Copy Markdown
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this in D78555763.

@cortinico
cortinico force-pushed the nc/oss-lib-cleanup branch from fbe9539 to 7bd15db Compare July 18, 2025 13:21
@github-actions

Copy link
Copy Markdown

Job Summary for Gradle

Test All :: build_android
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
react-native-github publishAllToMavenTempLocal build 8.14.3 Build Scan not published

@cortinico
cortinico force-pushed the nc/oss-lib-cleanup branch from 7bd15db to 4324853 Compare July 18, 2025 13:24
@github-actions

Copy link
Copy Markdown

Job Summary for Gradle

Test All :: build_android
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
react-native-github publishAllToMavenTempLocal build 8.14.3 Build Scan not published

@facebook-github-bot

Copy link
Copy Markdown
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this in D78555763.

@github-actions

Copy link
Copy Markdown

Job Summary for Gradle

Test All :: build_android
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
react-native-github publishAllToMavenTempLocal build 8.14.3 Build Scan not published

@facebook-github-bot

Copy link
Copy Markdown
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this in D78555763.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jul 22, 2025
@facebook-github-bot

Copy link
Copy Markdown
Contributor

@cortinico merged this pull request in 59101d6.

@react-native-bot

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @cortinico in 59101d6

When will my fix make it into a release? | How to file a pick request?

@matinzd

matinzd commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

I am wondering why apple stuff was not removed?

@cortinico

Copy link
Copy Markdown
Contributor Author

I am wondering why apple stuff was not removed?

Both Android and iOS were removed:

Screenshot 2026-08-03 at 23 04 32

@matinzd

matinzd commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Then probably some playground is left here: https://github.com/react/react-native/tree/main/packages/react-native-test-library

@cortinico

Copy link
Copy Markdown
Contributor Author

Then probably some playground is left here: main/packages/react-native-test-library

Ah that can go also. Don't you mind sending a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants