Skip to content

Commit d83d106

Browse files
j-piaseckimeta-codesync[bot]
authored andcommitted
Cover react/networking:networking with Stable API guards (#58008)
Summary: Pull Request resolved: #58008 Classifies `react/networking:networking` as a private target under the C++ stable API three-tier visibility model. Adds `#include <react/cxxstableapi/PrivateGuard.h>` to both of the module's exported headers (`NetworkReporter.h`, `NetworkTypes.h`), and wires the guard dependency into BUCK, CMake, and the podspec. The guards are inert unless a consumer defines `RN_STRICT_API`, so there is no behavior change. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D116591313 fbshipit-source-id: 4d789b42df63b61db3951712d59cdb1f4b03f90c
1 parent ea06a31 commit d83d106

4 files changed

Lines changed: 6 additions & 0 deletions

File tree

packages/react-native/ReactCommon/react/networking/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ target_link_libraries(react_networking
1919
folly_runtime
2020
jsinspector_network
2121
jsinspector_tracing
22+
react_cxxstableapi
2223
react_performance_timeline
2324
react_timing)
2425

packages/react-native/ReactCommon/react/networking/NetworkReporter.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/PrivateGuard.h>
11+
1012
#include "NetworkTypes.h"
1113

1214
#include <react/timing/primitives.h>

packages/react-native/ReactCommon/react/networking/NetworkTypes.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/PrivateGuard.h>
11+
1012
#include <map>
1113
#include <optional>
1214
#include <string>

packages/react-native/ReactCommon/react/networking/React-networking.podspec

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ Pod::Spec.new do |s|
4545
add_dependency(s, "React-jsinspectortracing", :framework_name => 'jsinspector_moderntracing')
4646
s.dependency "React-performancetimeline"
4747
s.dependency "React-timing"
48+
s.dependency "React-cxxstableapi"
4849

4950
add_rn_third_party_dependencies(s)
5051
add_rncore_dependency(s)

0 commit comments

Comments
 (0)