Wire pointer capture event props through the Fabric view config

Fabric declared onGotPointerCapture / onLostPointerCapture and the capture-phase pointer handlers in its view config, but never parsed them.

Fill in both prop parsing paths (convertRawProp and the iterator setProp), add the two missing capture phase offsets, and register the got/lost-capture bubbling event types and validAttributes on iOS and Android. Android was also missing the bubble-phase onPointerDown, onPointerUp and onPointerCancel attributes.

Author: yaminyassin

packages/react-native/Libraries/NativeComponent/BaseViewConfig.android.js

@@ -427,8 +427,14 @@ const validAttributesForEventProps = {
   // Pointer events
   onClick: true,
   onClickCapture: true,
+  onPointerCancel: true,
+  onPointerCancelCapture: true,
+  onPointerDown: true,
+  onPointerDownCapture: true,
   onPointerEnter: true,
   onPointerEnterCapture: true,
+  onPointerUp: true,
+  onPointerUpCapture: true,
   onPointerLeave: true,
   onPointerLeaveCapture: true,
   onPointerMove: true,

packages/react-native/Libraries/NativeComponent/BaseViewConfig.ios.js

@@ -411,16 +411,26 @@ const validAttributesForEventProps = ConditionallyIgnoredEventHandlers({
   // Pointer events
   onClick: true,
   onClickCapture: true,
-  onPointerUp: true,
-  onPointerDown: true,
   onPointerCancel: true,
+  onPointerCancelCapture: true,
+  onPointerDown: true,
+  onPointerDownCapture: true,
   onPointerEnter: true,
-  onPointerMove: true,
+  onPointerEnterCapture: true,
+  onPointerUp: true,
+  onPointerUpCapture: true,
   onPointerLeave: true,
-  onPointerOver: true,
+  onPointerLeaveCapture: true,
+  onPointerMove: true,
+  onPointerMoveCapture: true,
   onPointerOut: true,
+  onPointerOutCapture: true,
+  onPointerOver: true,
+  onPointerOverCapture: true,
   onGotPointerCapture: true,
+  onGotPointerCaptureCapture: true,
   onLostPointerCapture: true,
+  onLostPointerCaptureCapture: true,
 });
 
 /**

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/BaseViewManager.java

@@ -779,6 +779,18 @@ protected void onAfterUpdateTransaction(@NonNull T view) {
                 MapBuilder.of(
                     "phasedRegistrationNames",
                     MapBuilder.of("bubbled", "onPointerOver", "captured", "onPointerOverCapture")))
+            .put(
+                "topGotPointerCapture",
+                MapBuilder.of(
+                    "phasedRegistrationNames",
+                    MapBuilder.of(
+                        "bubbled", "onGotPointerCapture", "captured", "onGotPointerCaptureCapture")))
+            .put(
+                "topLostPointerCapture",
+                MapBuilder.of(
+                    "phasedRegistrationNames",
+                    MapBuilder.of(
+                        "bubbled", "onLostPointerCapture", "captured", "onLostPointerCaptureCapture")))
             .put(
                 "topClick",
                 MapBuilder.of(

packages/react-native/ReactCommon/react/renderer/components/view/BaseViewProps.cpp

@@ -455,7 +455,9 @@ void BaseViewProps::setProp(
     VIEW_EVENT_CASE(PointerUp);
     VIEW_EVENT_CASE(PointerUpCapture);
     VIEW_EVENT_CASE(GotPointerCapture);
+    VIEW_EVENT_CASE(GotPointerCaptureCapture);
     VIEW_EVENT_CASE(LostPointerCapture);
+    VIEW_EVENT_CASE(LostPointerCaptureCapture);
     VIEW_EVENT_CASE(MoveShouldSetResponder);
     VIEW_EVENT_CASE(MoveShouldSetResponderCapture);
     VIEW_EVENT_CASE(StartShouldSetResponder);

packages/react-native/ReactCommon/react/renderer/components/view/primitives.h

@@ -67,6 +67,8 @@ struct ViewEvents {
     PointerDownCapture = 35,
     PointerUp = 36,
     PointerUpCapture = 37,
+    GotPointerCaptureCapture = 38,
+    LostPointerCaptureCapture = 39,
   };
 
   constexpr bool operator[](const Offset offset) const

packages/react-native/ReactCommon/react/renderer/components/view/propsConversions.h

@@ -517,7 +517,30 @@ static inline ViewEvents convertRawProp(
       "onPointerUpCapture",
       sourceValue[Offset::PointerUpCapture],
       defaultValue[Offset::PointerUpCapture]);
-  // TODO: gotPointerCapture & lostPointerCapture
+  result[Offset::GotPointerCapture] = convertRawProp(
+      context,
+      rawProps,
+      "onGotPointerCapture",
+      sourceValue[Offset::GotPointerCapture],
+      defaultValue[Offset::GotPointerCapture]);
+  result[Offset::GotPointerCaptureCapture] = convertRawProp(
+      context,
+      rawProps,
+      "onGotPointerCaptureCapture",
+      sourceValue[Offset::GotPointerCaptureCapture],
+      defaultValue[Offset::GotPointerCaptureCapture]);
+  result[Offset::LostPointerCapture] = convertRawProp(
+      context,
+      rawProps,
+      "onLostPointerCapture",
+      sourceValue[Offset::LostPointerCapture],
+      defaultValue[Offset::LostPointerCapture]);
+  result[Offset::LostPointerCaptureCapture] = convertRawProp(
+      context,
+      rawProps,
+      "onLostPointerCaptureCapture",
+      sourceValue[Offset::LostPointerCaptureCapture],
+      defaultValue[Offset::LostPointerCaptureCapture]);
 
   // PanResponder callbacks
   result[Offset::MoveShouldSetResponder] = convertRawProp(

scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api

@@ -8060,7 +8060,9 @@ enum facebook::react::ViewEvents::Offset : std::size_t {
   Click,
   ClickCapture,
   GotPointerCapture,
+  GotPointerCaptureCapture,
   LostPointerCapture,
+  LostPointerCaptureCapture,
   MoveShouldSetResponder,
   MoveShouldSetResponderCapture,
   PointerDown,

scripts/cxx-api/api-snapshots/ReactAndroidNewarchCxx.api

@@ -7824,7 +7824,9 @@ enum facebook::react::ViewEvents::Offset : std::size_t {
   Click,
   ClickCapture,
   GotPointerCapture,
+  GotPointerCaptureCapture,
   LostPointerCapture,
+  LostPointerCaptureCapture,
   MoveShouldSetResponder,
   MoveShouldSetResponderCapture,
   PointerDown,

scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api

@@ -8051,7 +8051,9 @@ enum facebook::react::ViewEvents::Offset : std::size_t {
   Click,
   ClickCapture,
   GotPointerCapture,
+  GotPointerCaptureCapture,
   LostPointerCapture,
+  LostPointerCaptureCapture,
   MoveShouldSetResponder,
   MoveShouldSetResponderCapture,
   PointerDown,

scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api

@@ -10083,7 +10083,9 @@ enum facebook::react::ViewEvents::Offset : std::size_t {
   Click,
   ClickCapture,
   GotPointerCapture,
+  GotPointerCaptureCapture,
   LostPointerCapture,
+  LostPointerCaptureCapture,
   MoveShouldSetResponder,
   MoveShouldSetResponderCapture,
   PointerDown,