Commit 94566e2
Cover
Summary:
Pull Request resolved: #58121
Classifies `react/renderer/observers/events:events` as a private target under the C++ stable API three-tier visibility model. Adds `#include <react/cxxstableapi/PrivateGuard.h>` to the module's only exported header (`EventPerformanceLogger.h`), and wires the guard dependency into BUCK and CMake. On iOS the module ships as the `React-Fabric/observers/events` subspec, and the parent `React-Fabric` spec already depends on `React-cxxstableapi` from an earlier migration, so no podspec change is needed.
`Scheduler.h` is a "for frameworks" header that still includes `EventPerformanceLogger.h`, so the module is not cleanly private until that include is replaced with a forward declaration. That change is in review separately (D116909093) and can land in either order relative to this one, since the guards are inert on their own.
The guards are inert unless a consumer defines `RN_STRICT_API`, so there is no behavior change.
Changelog: [Internal]
Reviewed By: christophpurrer
Differential Revision: D117320589
fbshipit-source-id: 4e17fb4d25b1a51b2c06391d77cbe071b01ac3abreact/renderer/observers/events:events with Stable API guards (#58121)1 parent 60b08c6 commit 94566e2
2 files changed
Lines changed: 3 additions & 0 deletions
File tree
- packages/react-native/ReactCommon/react/renderer/observers/events
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| 16 | + | |
16 | 17 | | |
17 | 18 | | |
18 | 19 | | |
| |||
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| 10 | + | |
| 11 | + | |
10 | 12 | | |
11 | 13 | | |
12 | 14 | | |
| |||
0 commit comments