Upgrade Image visibility to "for frameworks" (#58283)

Summary:

Reclassifies `react/renderer/components/image:image` from public to "for frameworks" under the C++ stable API three-tier visibility model.

Consumers that opt into `RN_STRICT_API` now get a suppressible warning where they previously got an error pointing at the umbrella, and can acknowledge it with `RN_ALLOW_FRAMEWORKS`; without that flag the guards are inert, so no existing build changes behaviour.

Changelog: [Internal]

Reviewed By: christophpurrer

Differential Revision: D118440296

Author: j-piasecki

packages/react-native/ReactAndroid/build.gradle.kts

@@ -169,10 +169,6 @@ val preparePrefab by
                           "../ReactCommon/react/renderer/components/image/",
                           "react/renderer/components/image/",
                       ),
-                      Pair(
-                          "../ReactCommon/react/renderer/components/image/React/",
-                          "React/",
-                      ),
                       // rrc_view
                       Pair(
                           "../ReactCommon/react/renderer/components/view/",

packages/react-native/ReactCommon/React-FabricImage.podspec

@@ -43,19 +43,13 @@ Pod::Spec.new do |s|
   s.platforms              = min_supported_versions
   s.source                 = source
   s.source_files         = podspec_sources("react/renderer/components/image/**/*.{m,mm,cpp,h}", "react/renderer/components/image/**/*.h")
-  s.exclude_files        = ["react/renderer/components/image/tests", "react/renderer/components/image/React"]
+  s.exclude_files        = "react/renderer/components/image/tests"
   s.header_dir           = "react/renderer/components/image"
   s.pod_target_xcconfig = { "USE_HEADERMAP" => "YES",
                             "CLANG_CXX_LANGUAGE_STANDARD" => rct_cxx_language_standard(),
                             "HEADER_SEARCH_PATHS" => header_search_path.join(" ")
                           }
 
-  s.subspec "imageUmbrella" do |ss|
-    ss.source_files        = "react/renderer/components/image/React/*.h"
-    ss.header_dir          = ""
-    ss.header_mappings_dir = "react/renderer/components/image"
-  end
-
   resolve_use_frameworks(s, header_mappings_dir: './', module_name: "React_FabricImage")
 
   s.dependency "React-jsiexecutor", version

packages/react-native/ReactCommon/react/renderer/components/image/ImageComponentDescriptor.h

@@ -7,7 +7,7 @@
 
 #pragma once
 
-#include <react/cxxstableapi/UmbrellaGuard.h>
+#include <react/cxxstableapi/FrameworksGuard.h>
 
 #include <react/renderer/components/image/ImageShadowNode.h>
 #include <react/renderer/core/ConcreteComponentDescriptor.h>

packages/react-native/ReactCommon/react/renderer/components/image/ImageEventEmitter.h

@@ -7,7 +7,7 @@
 
 #pragma once
 
-#include <react/cxxstableapi/UmbrellaGuard.h>
+#include <react/cxxstableapi/FrameworksGuard.h>
 
 #include <react/renderer/components/view/ViewEventEmitter.h>
 #include <react/renderer/imagemanager/primitives.h>

packages/react-native/ReactCommon/react/renderer/components/image/ImageProps.h

@@ -7,7 +7,7 @@
 
 #pragma once
 
-#include <react/cxxstableapi/UmbrellaGuard.h>
+#include <react/cxxstableapi/FrameworksGuard.h>
 
 #include <react/renderer/components/view/ViewProps.h>
 #include <react/renderer/core/PropsParserContext.h>

packages/react-native/ReactCommon/react/renderer/components/image/ImageShadowNode.h

@@ -7,7 +7,7 @@
 
 #pragma once
 
-#include <react/cxxstableapi/UmbrellaGuard.h>
+#include <react/cxxstableapi/FrameworksGuard.h>
 
 #include <react/renderer/components/image/ImageEventEmitter.h>
 #include <react/renderer/components/image/ImageProps.h>

packages/react-native/ReactCommon/react/renderer/components/image/ImageState.h

@@ -7,7 +7,7 @@
 
 #pragma once
 
-#include <react/cxxstableapi/UmbrellaGuard.h>
+#include <react/cxxstableapi/FrameworksGuard.h>
 
 #include <react/renderer/imagemanager/ImageRequest.h>
 #include <react/renderer/imagemanager/ImageRequestParams.h>

packages/react-native/ReactCommon/react/renderer/components/image/React/Image.h

@@ -7,7 +7,7 @@
 
 #pragma once
 
-#include <react/cxxstableapi/UmbrellaGuard.h>
+#include <react/cxxstableapi/FrameworksGuard.h>
 
 #include <unordered_map>
 

packages/react-native/ReactCommon/react/renderer/components/image/conversions.h

@@ -491,22 +491,6 @@ const PodspecExceptions /*: {[key: string]: PodSpecConfiguration} */ = {
       },
     ],
   },
-  'ReactCommon/React-FabricImage.podspec': {
-    name: 'React-FabricImage',
-    headerPatterns: ['react/renderer/components/image/**/*.h'],
-    excludePatterns: [
-      'react/renderer/components/image/tests',
-      'react/renderer/components/image/React',
-    ],
-    headerDir: 'react/renderer/components/image',
-    subSpecs: [
-      {
-        name: 'imageUmbrella',
-        headerPatterns: ['react/renderer/components/image/React/*.h'],
-        headerDir: 'React',
-      },
-    ],
-  },
   'ReactCommon/callinvoker/React-callinvoker.podspec': {
     name: 'React-callinvoker',
     headerPatterns: ['**/*.h'],