Skip to content

Commit 5cd375f

Browse files
j-piaseckifacebook-github-bot
authored andcommitted
Cover react/nativemodule/dom with Stable API guards
Summary: Classifies `react/nativemodule/dom:dom` as a private target under the C++ stable API three-tier visibility model. Adds `#include <react/cxxstableapi/PrivateGuard.h>` to the module's single exported header (`NativeDOM.h`), and wires the guard dependency into BUCK, CMake, and the podspec. The guards are inert unless a consumer defines `RN_STRICT_API`, so there is no behavior change. Changelog: [Internal] Differential Revision: D117326651
1 parent 5b680c5 commit 5cd375f

3 files changed

Lines changed: 4 additions & 0 deletions

File tree

packages/react-native/ReactCommon/react/nativemodule/dom/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ add_library(react_nativemodule_dom
1818
target_include_directories(react_nativemodule_dom PUBLIC ${REACT_COMMON_DIR})
1919

2020
target_link_libraries(react_nativemodule_dom
21+
react_cxxstableapi
2122
rrc_root
2223
react_codegen_rncore
2324
react_cxxreact

packages/react-native/ReactCommon/react/nativemodule/dom/NativeDOM.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/PrivateGuard.h>
11+
1012
#include <string>
1113

1214
#if __has_include("FBReactNativeSpecJSI.h") // CocoaPod headers on Apple

packages/react-native/ReactCommon/react/nativemodule/dom/React-domnativemodule.podspec

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@ Pod::Spec.new do |s|
5555
s.dependency "React-Fabric"
5656
s.dependency "React-Fabric/bridging"
5757
s.dependency "React-FabricComponents"
58+
s.dependency "React-cxxstableapi"
5859
add_dependency(s, "React-runtimeexecutor", :additional_framework_paths => ["platform/ios"])
5960
add_dependency(s, "React-graphics", :additional_framework_paths => ["react/renderer/graphics/platform/ios"])
6061
add_dependency(s, "React-RCTFBReactNativeSpec")

0 commit comments

Comments
 (0)