Skip to content

Commit 26be0b2

Browse files
j-piaseckifacebook-github-bot
authored andcommitted
Cover react/renderer/runtimescheduler with Stable API guards (#58150)
Summary: Classifies `react/renderer/runtimescheduler:runtimescheduler` as a "for frameworks" target under the three-tier C++ stable API visibility model. Consumers that opt into `RN_STRICT_API` now get a warning if they include its headers directly, which they can acknowledge with `RN_ALLOW_FRAMEWORKS`; without that flag the guards are inert, so no existing build changes behaviour. `RuntimeScheduler_Legacy.h` gets its guard above the `RCT_REMOVE_LEGACY_ARCH` block so it is still evaluated when the legacy architecture is compiled out. Changelog: [Internal] Differential Revision: D117508561
1 parent 04e50d5 commit 26be0b2

13 files changed

Lines changed: 24 additions & 0 deletions

packages/react-native/ReactCommon/react/renderer/runtimescheduler/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ target_link_libraries(react_renderer_runtimescheduler
1717
callinvoker
1818
jserrorhandler
1919
jsi
20+
react_cxxstableapi
2021
react_debug
2122
react_performance_timeline
2223
react_renderer_consistency

packages/react-native/ReactCommon/react/renderer/runtimescheduler/React-runtimescheduler.podspec

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ Pod::Spec.new do |s|
4343
add_dependency(s, "React-runtimeexecutor", :additional_framework_paths => ["platform/ios"])
4444
s.dependency "React-callinvoker"
4545
s.dependency "React-cxxreact"
46+
s.dependency "React-cxxstableapi"
4647
s.dependency "React-rendererdebug"
4748
s.dependency "React-utils"
4849
s.dependency "React-featureflags"

packages/react-native/ReactCommon/react/renderer/runtimescheduler/RuntimeScheduler.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/FrameworksGuard.h>
11+
1012
#include <ReactCommon/RuntimeExecutor.h>
1113
#include <jsi/hermes-interfaces.h>
1214
#include <react/performance/timeline/PerformanceEntryReporter.h>

packages/react-native/ReactCommon/react/renderer/runtimescheduler/RuntimeSchedulerBinding.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/FrameworksGuard.h>
11+
1012
#include <jsi/jsi.h>
1113

1214
namespace facebook::react {

packages/react-native/ReactCommon/react/renderer/runtimescheduler/RuntimeSchedulerCallInvoker.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/FrameworksGuard.h>
11+
1012
#include <ReactCommon/CallInvoker.h>
1113
#include <memory>
1214

packages/react-native/ReactCommon/react/renderer/runtimescheduler/RuntimeSchedulerEventTimingDelegate.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/FrameworksGuard.h>
11+
1012
#include <react/timing/primitives.h>
1113
#include <unordered_set>
1214

packages/react-native/ReactCommon/react/renderer/runtimescheduler/RuntimeSchedulerIntersectionObserverDelegate.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/FrameworksGuard.h>
11+
1012
#include <unordered_set>
1113

1214
namespace facebook::react {

packages/react-native/ReactCommon/react/renderer/runtimescheduler/RuntimeSchedulerResizeObserverDelegate.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/FrameworksGuard.h>
11+
1012
#include <jsi/jsi.h>
1113

1214
namespace facebook::react {

packages/react-native/ReactCommon/react/renderer/runtimescheduler/RuntimeScheduler_Legacy.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/FrameworksGuard.h>
11+
1012
#ifndef RCT_REMOVE_LEGACY_ARCH
1113

1214
#include <ReactCommon/RuntimeExecutor.h>

packages/react-native/ReactCommon/react/renderer/runtimescheduler/RuntimeScheduler_Modern.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/FrameworksGuard.h>
11+
1012
#include <ReactCommon/RuntimeExecutor.h>
1113
#include <react/renderer/consistency/ShadowTreeRevisionConsistencyManager.h>
1214
#include <react/renderer/runtimescheduler/RuntimeScheduler.h>

0 commit comments

Comments
 (0)