Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong behaviour with Storybook 6.X #124

Open
vitorcamachoo opened this issue Feb 8, 2021 · 4 comments
Open

Wrong behaviour with Storybook 6.X #124

vitorcamachoo opened this issue Feb 8, 2021 · 4 comments

Comments

@vitorcamachoo
Copy link

vitorcamachoo commented Feb 8, 2021 •
edited
Loading

Hi,

After adding this addon to my storybook with version 6.X, I'm having some weird behaviours:

  • background of theme don't apply to component preview section
  • my addon panel is different from the displayed on README.md

Screenshot 2021-02-08 at 15 34 42

Screenshot 2021-02-08 at 15 34 05
@usulpro
Copy link
Member

usulpro commented Feb 8, 2021

Hey @vitorcamachoo
Yes background is out of the scope of this addon now as there is another addon to control backgrounds.
In readme is initial version of addon panel for old version of Material UI. Now it changed and not all features can be supported.

@vitorcamachoo
Copy link
Author

Hey @vitorcamachoo
Yes background is out of the scope of this addon now as there is another addon to control backgrounds.
In readme is initial version of addon panel for old version of Material UI. Now it changed and not all features can be supported.

Hi @usulpro
Any plans on supporting new version?

@usulpro
Copy link
Member

usulpro commented Feb 9, 2021

@vitorcamachoo the plan is to switch the core of this addon to another one: https://github.com/react-theming/storybook-addon#using-with-material-ui and maintain it as an extension of react-theming/storybook-addon

You can already switch to this new one by yourself, see how to use it with Material-UI in readme.

@vitorcamachoo
Copy link
Author

Thanks for the feedback. I will try your recomendation.

WULCAN added a commit to WULCAN/app.zetkin.org that referenced this issue Jun 26, 2024
@WULCAN
Replace storybook-addon-material-ui5
b1b3812 
The addon does not support Storybook 7 as it is still using default
export of @storybook/addons

The addon has not been developed since April 2023.

I don't see any of its functionality, other than applying the theme,
actually working with Storybook 6 either. The project it was forked
from has some open issues where others had similar problems.

react-theming/storybook-addon-material-ui#124
react-theming/storybook-addon-material-ui#97

I followed the guide from Ocotober 2022 for Material UI in Storybook to
activate our theme without storybook-addon-material-ui.

https://storybook.js.org/blog/material-ui-in-storybook/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@usulpro @vitorcamachoo