Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getAudioRoutes definition returns Promise<void>, but should return Promise<AudioRoute[]> #748

Open
3 tasks done
scarletcs opened this issue Nov 16, 2023 · 0 comments · May be fixed by #749
Open
3 tasks done

getAudioRoutes definition returns Promise<void>, but should return Promise<AudioRoute[]> #748

scarletcs opened this issue Nov 16, 2023 · 0 comments · May be fixed by #749

Comments

@scarletcs
Copy link

scarletcs commented Nov 16, 2023

Bug report

  • I've checked the example to reproduce the issue.

  • Reproduced on:

  • Android

  • iOS

Above are essentially N/A, this is a definitions bug that is reflected in the code editor.

Description

index.d.ts currently lists getAudioRoutes() as returning Promise<void>. The readme suggests it should be returning Promise<AudioRoute[]>, correlated by the Java module.

Using getAudioRoutes thus requires a cast of getAudioRoutes() as unknown as Promise<AudioRoute[]> or similar.

The problematic line is located here:

static getAudioRoutes(): Promise<void>

This appears to have been broken in this change: 0cba24e#diff-7aa4473ede4abd9ec099e87fec67fd57afafaf39e05d493ab4533acc38547eb8

Steps to Reproduce

Use getAudioRoutes() in your code editor.

Versions

- Callkeep: 4.3.12
- React Native: N/A
- iOS: N/A
- Android: N/A
- Phone model: N/A 

Logs

N/A

@scarletcs scarletcs linked a pull request Nov 16, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant