Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support latest GoogleSignIn ios SDK #707

Closed
Mayzie opened this issue Aug 16, 2019 · 7 comments
Closed

Support latest GoogleSignIn ios SDK #707

Mayzie opened this issue Aug 16, 2019 · 7 comments

Comments

@Mayzie
Copy link

Mayzie commented Aug 16, 2019

Issue

The GoogleSignIn Podfile was upgraded to 5.0.0 recently, which appears to have renamed (or deleted?) a few things. Attempting to compile [email protected] against this version results in the following error:

.../node_modules/react-native-google-signin/ios/RNGoogleSignin/RNGoogleSignin.h:11:74: Cannot find protocol declaration for 'GIDSignInUIDelegate'; did you mean 'GIDSignInDelegate'?

Environment

iOS

@TWBestATM
Copy link

TWBestATM commented Aug 17, 2019

are u fix that?

@joaopaulorefatti
Copy link

same problem!

@varyP
Copy link

varyP commented Aug 19, 2019

Possible to find a documentation, to what has changed?

@vonovak
Copy link
Member

vonovak commented Aug 27, 2019

here's the changelog https://developers.google.com/identity/sign-in/ios/release

if someone wants to migrate the apis to v5, feel free to contribute! Thanks.

@vonovak vonovak changed the title Support latest GoogleSignIn Podfile (4.4.0 -> 5.0.0) Support latest GoogleSignIn ios SDK Aug 27, 2019
D1verGW added a commit to D1verGW/react-native-google-signin that referenced this issue Sep 5, 2019
@martsie
Copy link

martsie commented Sep 5, 2019

For people who landed here and don't want to update react-native-google-signin you can head to your podfile and force GoogleSignIn to use the older version for now

pod 'GoogleSignIn', '4.4.0'

and run a pod update

@vonovak
Copy link
Member

vonovak commented Oct 3, 2019

done in v3

@vonovak vonovak closed this as completed Oct 3, 2019
@react-native-google-signin react-native-google-signin locked and limited conversation to collaborators Oct 3, 2019
@vonovak
Copy link
Member

vonovak commented Mar 4, 2020

if someone encounters the error, removing the ios/build folder, cleaning the project and removing derived data should help

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
6 participants