Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit ebe9e88

Browse files
afc163afc163
authoredOct 13, 2023
revert: search aria-label (#985)
1 parent d5442ba commit ebe9e88

File tree

6 files changed

+1
-18
lines changed

6 files changed

+1
-18
lines changed
 

‎src/Selector/Input.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,6 @@ const Input: React.RefForwardingComponent<InputRef, InputProps> = (
9090
className: classNames(`${prefixCls}-selection-search-input`, inputNode?.props?.className),
9191

9292
role: 'combobox',
93-
'aria-label': 'Search',
9493
'aria-expanded': open || false,
9594
'aria-haspopup': 'listbox',
9695
'aria-owns': `${id}_list`,

‎tests/__snapshots__/Combobox.test.tsx.snap

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ exports[`Select.Combobox renders controlled correctly 1`] = `
1515
aria-controls="rc_select_TEST_OR_SSR_list"
1616
aria-expanded="false"
1717
aria-haspopup="listbox"
18-
aria-label="Search"
1918
aria-owns="rc_select_TEST_OR_SSR_list"
2019
autocomplete="off"
2120
class="rc-select-selection-search-input"
@@ -49,7 +48,6 @@ exports[`Select.Combobox renders correctly 1`] = `
4948
aria-controls="rc_select_TEST_OR_SSR_list"
5049
aria-expanded="false"
5150
aria-haspopup="listbox"
52-
aria-label="Search"
5351
aria-owns="rc_select_TEST_OR_SSR_list"
5452
autocomplete="off"
5553
class="rc-select-selection-search-input"

‎tests/__snapshots__/Multiple.test.tsx.snap

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ exports[`Select.Multiple render not display maxTagPlaceholder if maxTagCount not
2323
aria-controls="rc_select_TEST_OR_SSR_list"
2424
aria-expanded="false"
2525
aria-haspopup="listbox"
26-
aria-label="Search"
2726
aria-owns="rc_select_TEST_OR_SSR_list"
2827
autocomplete="off"
2928
class="rc-select-selection-search-input"
@@ -144,7 +143,6 @@ exports[`Select.Multiple render truncates tags by maxTagCount and show maxTagPla
144143
aria-controls="rc_select_TEST_OR_SSR_list"
145144
aria-expanded="false"
146145
aria-haspopup="listbox"
147-
aria-label="Search"
148146
aria-owns="rc_select_TEST_OR_SSR_list"
149147
autocomplete="off"
150148
class="rc-select-selection-search-input"
@@ -262,7 +260,6 @@ exports[`Select.Multiple render truncates tags by maxTagCount and show maxTagPla
262260
aria-controls="rc_select_TEST_OR_SSR_list"
263261
aria-expanded="false"
264262
aria-haspopup="listbox"
265-
aria-label="Search"
266263
aria-owns="rc_select_TEST_OR_SSR_list"
267264
autocomplete="off"
268265
class="rc-select-selection-search-input"
@@ -364,7 +361,6 @@ exports[`Select.Multiple render truncates values by maxTagTextLength 1`] = `
364361
aria-controls="rc_select_TEST_OR_SSR_list"
365362
aria-expanded="false"
366363
aria-haspopup="listbox"
367-
aria-label="Search"
368364
aria-owns="rc_select_TEST_OR_SSR_list"
369365
autocomplete="off"
370366
class="rc-select-selection-search-input"

‎tests/__snapshots__/Select.test.tsx.snap

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,6 @@ exports[`Select.Basic no search 1`] = `
123123
aria-controls="undefined_list"
124124
aria-expanded="false"
125125
aria-haspopup="listbox"
126-
aria-label="Search"
127126
aria-owns="undefined_list"
128127
autocomplete="off"
129128
class="rc-select-selection-search-input"
@@ -209,7 +208,6 @@ exports[`Select.Basic render renders correctly 1`] = `
209208
aria-controls="undefined_list"
210209
aria-expanded="false"
211210
aria-haspopup="listbox"
212-
aria-label="Search"
213211
aria-owns="undefined_list"
214212
autocomplete="off"
215213
class="antd-selection-search-input"
@@ -257,7 +255,6 @@ exports[`Select.Basic render renders data-attributes correctly 1`] = `
257255
aria-controls="undefined_list"
258256
aria-expanded="false"
259257
aria-haspopup="listbox"
260-
aria-label="Search"
261258
aria-owns="undefined_list"
262259
autocomplete="off"
263260
class="antd-selection-search-input"
@@ -303,7 +300,6 @@ exports[`Select.Basic render renders disabled select correctly 1`] = `
303300
aria-controls="undefined_list"
304301
aria-expanded="false"
305302
aria-haspopup="listbox"
306-
aria-label="Search"
307303
aria-owns="undefined_list"
308304
autocomplete="off"
309305
class="antd-selection-search-input"
@@ -341,7 +337,6 @@ exports[`Select.Basic render renders role prop correctly 1`] = `
341337
aria-controls="undefined_list"
342338
aria-expanded="false"
343339
aria-haspopup="listbox"
344-
aria-label="Search"
345340
aria-owns="undefined_list"
346341
autocomplete="off"
347342
class="antd-selection-search-input"

‎tests/__snapshots__/Tags.test.tsx.snap

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,6 @@ exports[`Select.Tags OptGroup renders correctly 1`] = `
7979
aria-controls="rc_select_TEST_OR_SSR_list"
8080
aria-expanded="true"
8181
aria-haspopup="listbox"
82-
aria-label="Search"
8382
aria-owns="rc_select_TEST_OR_SSR_list"
8483
autocomplete="off"
8584
class="rc-select-selection-search-input"
@@ -253,7 +252,6 @@ exports[`Select.Tags render not display maxTagPlaceholder if maxTagCount not rea
253252
aria-controls="rc_select_TEST_OR_SSR_list"
254253
aria-expanded="false"
255254
aria-haspopup="listbox"
256-
aria-label="Search"
257255
aria-owns="rc_select_TEST_OR_SSR_list"
258256
autocomplete="off"
259257
class="rc-select-selection-search-input"
@@ -371,7 +369,6 @@ exports[`Select.Tags render truncates tags by maxTagCount and show maxTagPlaceho
371369
aria-controls="rc_select_TEST_OR_SSR_list"
372370
aria-expanded="false"
373371
aria-haspopup="listbox"
374-
aria-label="Search"
375372
aria-owns="rc_select_TEST_OR_SSR_list"
376373
autocomplete="off"
377374
class="rc-select-selection-search-input"
@@ -486,7 +483,6 @@ exports[`Select.Tags render truncates tags by maxTagCount and show maxTagPlaceho
486483
aria-controls="rc_select_TEST_OR_SSR_list"
487484
aria-expanded="false"
488485
aria-haspopup="listbox"
489-
aria-label="Search"
490486
aria-owns="rc_select_TEST_OR_SSR_list"
491487
autocomplete="off"
492488
class="rc-select-selection-search-input"
@@ -585,7 +581,6 @@ exports[`Select.Tags render truncates values by maxTagTextLength 1`] = `
585581
aria-controls="rc_select_TEST_OR_SSR_list"
586582
aria-expanded="false"
587583
aria-haspopup="listbox"
588-
aria-label="Search"
589584
aria-owns="rc_select_TEST_OR_SSR_list"
590585
autocomplete="off"
591586
class="rc-select-selection-search-input"

‎tests/__snapshots__/ssr.test.tsx.snap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
// Jest Snapshot v1, https://goo.gl/fbAQLP
22

3-
exports[`Select.SSR should work 1`] = `"<div class="rc-select rc-select-single"><div class="rc-select-selector"><span class="rc-select-selection-search"><input type="search" autoComplete="off" class="rc-select-selection-search-input" role="combobox" aria-label="Search" aria-expanded="false" aria-haspopup="listbox" aria-owns="undefined_list" aria-autocomplete="list" aria-controls="undefined_list" value="" readonly="" unselectable="on" style="opacity:0"/></span><span class="rc-select-selection-placeholder"></span></div></div>"`;
3+
exports[`Select.SSR should work 1`] = `"<div class="rc-select rc-select-single"><div class="rc-select-selector"><span class="rc-select-selection-search"><input type="search" autoComplete="off" class="rc-select-selection-search-input" role="combobox" aria-expanded="false" aria-haspopup="listbox" aria-owns="undefined_list" aria-autocomplete="list" aria-controls="undefined_list" value="" readonly="" unselectable="on" style="opacity:0"/></span><span class="rc-select-selection-placeholder"></span></div></div>"`;

0 commit comments

Comments
 (0)
Please sign in to comment.