Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query Params ignored for isCurrent #479

Open
SimonChaumet opened this issue Jul 23, 2021 · 0 comments
Open

Query Params ignored for isCurrent #479

SimonChaumet opened this issue Jul 23, 2021 · 0 comments

Comments

@SimonChaumet
Copy link

Bug

When using query params (search params) the query is ignored when taken from location but it's not when using the "to" parameter, so isCurrent will never be true when using query params. I think this is the corresponding code.

I know that it might be a problem for the specifications but I think a consistent logic would be to ignore the query params from the "to" parameter.

See CodeSandbox

I may provide a pull request if the specification is good for you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant