Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed API to take a script tag as child, instead of a textNode #8

Closed
wants to merge 9 commits into from
Closed

Changed API to take a script tag as child, instead of a textNode #8

wants to merge 9 commits into from

Conversation

bennypowers
Copy link

@bennypowers bennypowers commented Feb 21, 2018 •
edited
Loading

Fixes #5

Also implements

  • fetchResults
  • notifyOnNetworkStatusChange
  • pollInterval

and fixes a bug in graphql-mutation (forgot to return the response in the promise)

Sorry for the multi-issue PR, I'm on a deadline at work :D

@FluorescentHallucinogen
Copy link
Collaborator

@paales Please review this pull request.

@paales
Copy link
Contributor

paales commented Oct 27, 2018

@paales paales closed this Oct 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<graphql-query> should take a <script> tag
3 participants
@bennypowers @FluorescentHallucinogen @paales