Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[names] Search by common name #9

Open
re1 opened this issue Aug 30, 2019 · 2 comments
Open

[names] Search by common name #9

re1 opened this issue Aug 30, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@re1
Copy link
Owner

re1 commented Aug 30, 2019

While the application currently only supports searching by scientific names it might be a good idea to support common names too. Common names are already saved to the database and mostly searchable from a source's web interface.

Both common names and scientific names could be queried from the same function as a common name query would also return matching scientific names and vice versa.

It might be a good idea to provide interfaces specific to either common names and scientific names too as they might decrease response times.

When returning scientific names for common names a second type parameter makes sense so either one can be filtered after using the shared interface.

@re1 re1 added the enhancement New feature or request label Aug 30, 2019
@re1 re1 self-assigned this Aug 30, 2019
@re1
Copy link
Owner Author

re1 commented Aug 30, 2019

An attempt was made about two years ago on feature branch reverse_common_names_search but it was neither merged nor documented. Implementations will be evaluated and added soon.

Changes can be compared here: https://github.com/re1/jacq-javaee/compare/names...re1:feature%2Freverse_common_names_search?diff=unified.
Merge will most likely happen manually.

@re1
Copy link
Owner Author

re1 commented Sep 1, 2019

Changes can be compared here: https://github.com/re1/jacq-javaee/compare/names...re1:feature%2Freverse_common_names_search?diff=unified.
Merge will most likely happen manually.

Branch has been merged manually excluding the shared names path which will be implemented with a working reverse common name search solution.

@re1 re1 removed their assignment Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant