Fixing syntax error in todos.md #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes two small code issues that I came across was I was following the tutorial: First, a syntax error in `todoActions$`. Secondly, a TypeScript warning in the definition of `useTodos`: ``` Type 'IterableIterator<Todo>' can only be iterated through when using the '--downlevelIteration' flag or with a '--target' of 'es2015' or higher. ``` Replacing `[...todosMap.values()]` with `Array.from(todosMap.values())` makes that warning go away without customising TypeScript from its default value.
Hey, just a heads up - I just check the calendar and we're actually in 2023! Crazy, right!? Time flies... 😜 If you're still rocking those This library is very unapologetic about keeping up with the latest TypeScript versions and configurations. So, thanks for the suggestion, but we think we'll stick with what we've got. |
Ups! I missed this. This is a good change, actually. Sorry, that I missed that. Could you please leave the |
sebmos
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed two small code issues while going through the tutorials:
First, a syntax error in
todoActions$.Second, a TypeScript warning in the definition of
useTodos:Replacing
[...todosMap.values()]withArray.from(todosMap.values())makes that warning go away without customising TypeScript from its default value.