RDKEMW-6891: Coverity errors fix for xdial

mukesh972 · mukesh972 · commit fd6f79c31c9c · 2025-08-21T10:46:35.000+05:30
diff --git a/server/gdial-rest.c b/server/gdial-rest.c
@@ -22,6 +22,8 @@
 #include <stdio.h>
 #include <netinet/in.h>
 #include <sys/socket.h>
+#include <stdint.h>
+#include <inttypes.h>
 
 #include <glib.h>
 #include <libsoup/soup.h>
@@ -159,7 +161,7 @@ static GList *gdial_rest_server_registered_apps_clear(GDialRestServer *self, GLi
   GDialRestServerPrivate *priv = gdial_rest_server_get_instance_private(self);
   GDialAppRegistry *app_registry = (GDialAppRegistry *)found->data;
   registered_apps = g_list_remove_link(registered_apps, found);
-  GDIAL_LOGINFO("gdial_local_rest_http_server_callback handler Removed for App[%s]instance[%x]", app_registry->name,priv->local_soup_instance);
+  GDIAL_LOGINFO("gdial_local_rest_http_server_callback handler Removed for App[%s]instance[%x]", app_registry->name,(uintptr_t)priv->local_soup_instance);
   soup_server_remove_handler(priv->local_soup_instance, app_registry->app_uri);
   gdial_app_regstry_dispose (app_registry);
   g_list_free(found);
@@ -712,7 +714,10 @@ static void gdial_local_rest_http_server_callback(SoupServer *server,
       continue;
     }
     if (j == 0) {
-        g_strlcpy(base, elements[i], sizeof(base));
+        ret = g_strlcpy(base, elements[i], sizeof(base));
+	if (ret >= sizeof(base)) {
+            GDIAL_LOGERROR("Warn: base too long");
+        }
     }
     else if (j == 1) {
         ret = g_strlcpy(instance, elements[i], sizeof(instance));
@@ -1165,7 +1170,7 @@ gboolean gdial_rest_server_register_app(GDialRestServer *self, const gchar *app_
 
   if( 0 != strcmp(app_name,"system"))
   {
-    GDIAL_LOGINFO("gdial_local_rest_http_server_callback handler added for App[%s]uri[%s]instance[%x]",app_name,app_registry->app_uri,priv->local_soup_instance);
+    GDIAL_LOGINFO("gdial_local_rest_http_server_callback handler added for App[%s]uri[%s]instance[%x]",app_name,app_registry->app_uri,(uintptr_t)priv->local_soup_instance);
     soup_server_add_handler(priv->local_soup_instance, app_registry->app_uri, gdial_local_rest_http_server_callback, self, NULL);
   }
   GDIAL_LOGTRACE("Exiting ...");
@@ -1197,7 +1202,7 @@ gboolean gdial_rest_server_register_app_registry(GDialRestServer *self, GDialApp
   g_return_val_if_fail(gdial_rest_server_is_app_registered(self, app_registry->name), FALSE);
   if( 0 != strcmp(app_registry->name,"system"))
   {
-    GDIAL_LOGINFO("gdial_local_rest_http_server_callback handler added for App[%s]uri[%s]instance[%x]",app_registry->name,app_registry->app_uri,priv->local_soup_instance);
+    GDIAL_LOGINFO("gdial_local_rest_http_server_callback handler added for App[%s]uri[%s]instance[%x]",app_registry->name,app_registry->app_uri,(uintptr_t)priv->local_soup_instance);
     soup_server_add_handler(priv->local_soup_instance, app_registry->app_uri, gdial_local_rest_http_server_callback, self, NULL);
   }
   return TRUE;
@@ -1360,4 +1365,4 @@ GDIAL_STATIC_INLINE void GET_APP_response_builder_destroy(void *builder) {
   g_free(rbuilder->additionalData);
 
   g_free(builder);
-}
+}
diff --git a/server/gdialserver_ut.cpp b/server/gdialserver_ut.cpp
@@ -43,7 +43,7 @@ class gdialServiceTest: public GDialNotifier
         {
             GDIAL_LOGINFO("Entering ...");
             std::string activation = status ? "true" : "false";
-            service->ActivationChanged(activation,"SampleTest");
+            service->ActivationChanged(std::move(activation),"SampleTest");
             GDIAL_LOGINFO("Exiting ...");
         }
 
@@ -137,9 +137,9 @@ class gdialServiceTest: public GDialNotifier
                     break;
                 }
                 
-                appReq->Names = Names;
+                appReq->Names = std::move(Names);
                 appReq->prefixes = prefixes;
-                appReq->cors = prefixes;
+                appReq->cors = std::move(prefixes);
                 appReq->allowStop = allowStop;
 
                 appReqList->pushBack(appReq);
@@ -253,4 +253,4 @@ int main(int argc, char *argv[])
     delete testObject;
 
     return 0;
-}
+}
diff --git a/server/plat/gdial-plat-util.c b/server/plat/gdial-plat-util.c
@@ -128,4 +128,4 @@ void gdial_plat_util_log(gdial_plat_util_LogLevel level,
                 func,
                 formatted);
     fflush(stderr);
-}
+}
diff --git a/server/plat/gdial.cpp b/server/plat/gdial.cpp
@@ -82,6 +82,10 @@ class GDialCastObject
                 reterror = GDIAL_CAST_ERROR_NONE;
             }
         }
+	else
+	{
+		delete AppObj; // fix RESOURCE_LEAK coverity
+	}
         GDIAL_LOGTRACE("Exiting ...");
         return reterror;
     }
@@ -239,7 +243,7 @@ class GDialCastObject
         GDIAL_LOGINFO("App[%s] param[%s] observer[%p]",applicationName.c_str(),parameter.c_str(),m_observer);
         if (nullptr!=m_observer)
         {
-            m_observer->onApplicationLaunchRequest(applicationName,parameter);
+            m_observer->onApplicationLaunchRequest(std::move(applicationName),std::move(parameter));
         }
         GDIAL_LOGTRACE("Exiting ...");
         return GDIAL_CAST_ERROR_NONE;
@@ -274,10 +278,10 @@ class GDialCastObject
                 m_observer);
         if (nullptr!=m_observer)
         {
-            m_observer->onApplicationLaunchRequestWithLaunchParam( applicationName,
-                                                                   payLoad,
-                                                                   queryString,
-                                                                   additionalDataUrl );
+            m_observer->onApplicationLaunchRequestWithLaunchParam( std::move(applicationName),
+                                                                   std::move(payLoad),
+                                                                   std::move(queryString),
+                                                                   std::move(additionalDataUrl) );
         }
         GDIAL_LOGTRACE("Exiting ...");
         return GDIAL_CAST_ERROR_NONE;
@@ -298,7 +302,7 @@ class GDialCastObject
         GDIAL_LOGINFO("App[%s]ID[%s]observer[%p]",applicationName.c_str(),applicationId.c_str(),m_observer);
         if (nullptr!=m_observer)
         {
-            m_observer->onApplicationHideRequest(applicationName,applicationId);
+            m_observer->onApplicationHideRequest(std::move(applicationName),std::move(applicationId));
         }
         GDIAL_LOGTRACE("Exiting ...");
         return GDIAL_CAST_ERROR_NONE;
@@ -320,7 +324,7 @@ class GDialCastObject
         GDIAL_LOGINFO("App[%s]ID[%s]observer[%p]",applicationName.c_str(),applicationId.c_str(),m_observer);
         if (nullptr!=m_observer)
         {
-            m_observer->onApplicationResumeRequest(applicationName,applicationId);
+            m_observer->onApplicationResumeRequest(std::move(applicationName),std::move(applicationId));
         }
         GDIAL_LOGTRACE("Exiting ...");
         return GDIAL_CAST_ERROR_NONE;
@@ -342,7 +346,7 @@ class GDialCastObject
         GDIAL_LOGINFO("App[%s]ID[%s]observer[%p]",applicationName.c_str(),applicationId.c_str(),m_observer);
         if (nullptr!=m_observer)
         {
-            m_observer->onApplicationStopRequest(applicationName,applicationId);
+            m_observer->onApplicationStopRequest(std::move(applicationName),std::move(applicationId));
         }
         GDIAL_LOGTRACE("Exiting ...");
         return GDIAL_CAST_ERROR_NONE;
@@ -364,7 +368,7 @@ class GDialCastObject
         GDIAL_LOGINFO("App[%s]ID[%s]observer[%p]",applicationName.c_str(),applicationId.c_str(),m_observer);
         if (nullptr!=m_observer)
         {
-            m_observer->onApplicationStateRequest(applicationName,applicationId);
+            m_observer->onApplicationStateRequest(std::move(applicationName),std::move(applicationId));
         }
         GDIAL_LOGTRACE("Exiting ...");
         return GDIAL_CAST_ERROR_NONE;
diff --git a/server/plat/gdialappcache.cpp b/server/plat/gdialappcache.cpp
@@ -44,12 +44,12 @@ void GDialAppStatusCache :: setAppCacheId(std::string app_name,std::string id)
     GDIAL_LOGTRACE("Entering ...");
     if(!strcmp(app_name.c_str(),"Netflix"))
     {
-        GDialAppStatusCache::Netflix_AppCacheId = id;
+        GDialAppStatusCache::Netflix_AppCacheId = std::move(id);
         GDIAL_LOGINFO("App cache Id of Netflix updated to %s",GDialAppStatusCache::Netflix_AppCacheId.c_str());
     }
     else if(!strcmp(app_name.c_str(),"YouTube"))
     {
-        GDialAppStatusCache::Youtube_AppCacheId = id;
+        GDialAppStatusCache::Youtube_AppCacheId = std::move(id);
         GDIAL_LOGINFO("App cache Id of Youtube updated to %s",GDialAppStatusCache::Youtube_AppCacheId.c_str());
     }
     else
@@ -75,7 +75,7 @@ AppCacheErrorCodes GDialAppStatusCache::UpdateAppStatusCache(AppInfo* appEntry)
         GDIAL_LOGINFO("erasing old data");
         err = ObjectCache->erase(id);
     }
-    err = ObjectCache->insert(id,appEntry);
+    err = ObjectCache->insert(std::move(id),appEntry);
     GDIAL_LOGTRACE("Exiting ...");
     return err;
 }
@@ -96,7 +96,7 @@ std::string GDialAppStatusCache::SearchAppStatusInCache(const char* app_name)
             appEntry->appId.c_str(),
             appEntry->appError.c_str());
     }
-    GDIAL_LOGINFO("App State = ",state.c_str());
+    GDIAL_LOGINFO("App State = %s ",state.c_str());
     GDIAL_LOGTRACE("Exiting ...");
     return state;
 }

Original file line number	Diff line number	Diff line change
`@@ -82,6 +82,10 @@ class GDialCastObject`
`82`	`82`	`reterror = GDIAL_CAST_ERROR_NONE;`
`83`	`83`	`}`
`84`	`84`	`}`
	`85`	`+ else`
	`86`	`+ {`
	`87`	`+ delete AppObj; // fix RESOURCE_LEAK coverity`
	`88`	`+ }`
`85`	`89`	`GDIAL_LOGTRACE("Exiting ...");`
`86`	`90`	`return reterror;`
`87`	`91`	`}`
`@@ -239,7 +243,7 @@ class GDialCastObject`
`239`	`243`	`GDIAL_LOGINFO("App[%s] param[%s] observer[%p]",applicationName.c_str(),parameter.c_str(),m_observer);`
`240`	`244`	`if (nullptr!=m_observer)`
`241`	`245`	`{`
`242`		`- m_observer->onApplicationLaunchRequest(applicationName,parameter);`
	`246`	`+ m_observer->onApplicationLaunchRequest(std::move(applicationName),std::move(parameter));`
`243`	`247`	`}`
`244`	`248`	`GDIAL_LOGTRACE("Exiting ...");`
`245`	`249`	`return GDIAL_CAST_ERROR_NONE;`
`@@ -274,10 +278,10 @@ class GDialCastObject`
`274`	`278`	`m_observer);`
`275`	`279`	`if (nullptr!=m_observer)`
`276`	`280`	`{`
`277`		`- m_observer->onApplicationLaunchRequestWithLaunchParam( applicationName,`
`278`		`- payLoad,`
`279`		`- queryString,`
`280`		`- additionalDataUrl );`
	`281`	`+ m_observer->onApplicationLaunchRequestWithLaunchParam( std::move(applicationName),`
	`282`	`+ std::move(payLoad),`
	`283`	`+ std::move(queryString),`
	`284`	`+ std::move(additionalDataUrl) );`
`281`	`285`	`}`
`282`	`286`	`GDIAL_LOGTRACE("Exiting ...");`
`283`	`287`	`return GDIAL_CAST_ERROR_NONE;`
`@@ -298,7 +302,7 @@ class GDialCastObject`
`298`	`302`	`GDIAL_LOGINFO("App[%s]ID[%s]observer[%p]",applicationName.c_str(),applicationId.c_str(),m_observer);`
`299`	`303`	`if (nullptr!=m_observer)`
`300`	`304`	`{`
`301`		`- m_observer->onApplicationHideRequest(applicationName,applicationId);`
	`305`	`+ m_observer->onApplicationHideRequest(std::move(applicationName),std::move(applicationId));`
`302`	`306`	`}`
`303`	`307`	`GDIAL_LOGTRACE("Exiting ...");`
`304`	`308`	`return GDIAL_CAST_ERROR_NONE;`
`@@ -320,7 +324,7 @@ class GDialCastObject`
`320`	`324`	`GDIAL_LOGINFO("App[%s]ID[%s]observer[%p]",applicationName.c_str(),applicationId.c_str(),m_observer);`
`321`	`325`	`if (nullptr!=m_observer)`
`322`	`326`	`{`
`323`		`- m_observer->onApplicationResumeRequest(applicationName,applicationId);`
	`327`	`+ m_observer->onApplicationResumeRequest(std::move(applicationName),std::move(applicationId));`
`324`	`328`	`}`
`325`	`329`	`GDIAL_LOGTRACE("Exiting ...");`
`326`	`330`	`return GDIAL_CAST_ERROR_NONE;`
`@@ -342,7 +346,7 @@ class GDialCastObject`
`342`	`346`	`GDIAL_LOGINFO("App[%s]ID[%s]observer[%p]",applicationName.c_str(),applicationId.c_str(),m_observer);`
`343`	`347`	`if (nullptr!=m_observer)`
`344`	`348`	`{`
`345`		`- m_observer->onApplicationStopRequest(applicationName,applicationId);`
	`349`	`+ m_observer->onApplicationStopRequest(std::move(applicationName),std::move(applicationId));`
`346`	`350`	`}`
`347`	`351`	`GDIAL_LOGTRACE("Exiting ...");`
`348`	`352`	`return GDIAL_CAST_ERROR_NONE;`
`@@ -364,7 +368,7 @@ class GDialCastObject`
`364`	`368`	`GDIAL_LOGINFO("App[%s]ID[%s]observer[%p]",applicationName.c_str(),applicationId.c_str(),m_observer);`
`365`	`369`	`if (nullptr!=m_observer)`
`366`	`370`	`{`
`367`		`- m_observer->onApplicationStateRequest(applicationName,applicationId);`
	`371`	`+ m_observer->onApplicationStateRequest(std::move(applicationName),std::move(applicationId));`
`368`	`372`	`}`
`369`	`373`	`GDIAL_LOGTRACE("Exiting ...");`
`370`	`374`	`return GDIAL_CAST_ERROR_NONE;`
Original file line number	Diff line number	Diff line change
`@@ -44,12 +44,12 @@ void GDialAppStatusCache :: setAppCacheId(std::string app_name,std::string id)`
`44`	`44`	`GDIAL_LOGTRACE("Entering ...");`
`45`	`45`	`if(!strcmp(app_name.c_str(),"Netflix"))`
`46`	`46`	`{`
`47`		`- GDialAppStatusCache::Netflix_AppCacheId = id;`
	`47`	`+ GDialAppStatusCache::Netflix_AppCacheId = std::move(id);`
`48`	`48`	`GDIAL_LOGINFO("App cache Id of Netflix updated to %s",GDialAppStatusCache::Netflix_AppCacheId.c_str());`
`49`	`49`	`}`
`50`	`50`	`else if(!strcmp(app_name.c_str(),"YouTube"))`
`51`	`51`	`{`
`52`		`- GDialAppStatusCache::Youtube_AppCacheId = id;`
	`52`	`+ GDialAppStatusCache::Youtube_AppCacheId = std::move(id);`
`53`	`53`	`GDIAL_LOGINFO("App cache Id of Youtube updated to %s",GDialAppStatusCache::Youtube_AppCacheId.c_str());`
`54`	`54`	`}`
`55`	`55`	`else`
`@@ -75,7 +75,7 @@ AppCacheErrorCodes GDialAppStatusCache::UpdateAppStatusCache(AppInfo* appEntry)`
`75`	`75`	`GDIAL_LOGINFO("erasing old data");`
`76`	`76`	`err = ObjectCache->erase(id);`
`77`	`77`	`}`
`78`		`- err = ObjectCache->insert(id,appEntry);`
	`78`	`+ err = ObjectCache->insert(std::move(id),appEntry);`
`79`	`79`	`GDIAL_LOGTRACE("Exiting ...");`
`80`	`80`	`return err;`
`81`	`81`	`}`
`@@ -96,7 +96,7 @@ std::string GDialAppStatusCache::SearchAppStatusInCache(const char* app_name)`
`96`	`96`	`appEntry->appId.c_str(),`
`97`	`97`	`appEntry->appError.c_str());`
`98`	`98`	`}`
`99`		`- GDIAL_LOGINFO("App State = ",state.c_str());`
	`99`	`+ GDIAL_LOGINFO("App State = %s ",state.c_str());`
`100`	`100`	`GDIAL_LOGTRACE("Exiting ...");`
`101`	`101`	`return state;`
`102`	`102`	`}`