maintain config backwards compat

Author: jpuck

src/StudentAffairsUwm/Shibboleth/ConfigurationBackwardsCompatabilityMapper.php

@@ -0,0 +1,19 @@
+<?php
+
+namespace StudentAffairsUwm\Shibboleth;
+
+class ConfigurationBackwardsCompatabilityMapper
+{
+    public static function map()
+    {
+        foreach ([
+            'entitlement'     => 'idp_login_entitlement',
+            'user.email'      => 'idp_login_email',
+            'user.name'       => 'idp_login_name',
+            'user.first_name' => 'idp_login_first_name',
+            'user.last_name'  => 'idp_login_last_name',
+        ] as $new => $old) {
+            config(["shibboleth.$new" => config("shibboleth.$old")]);
+        }
+    }
+}

src/StudentAffairsUwm/Shibboleth/Controllers/ShibbolethController.php

@@ -15,6 +15,7 @@
 use JWTAuth;
 use Illuminate\Database\Eloquent\ModelNotFoundException;
 use StudentAffairsUwm\Shibboleth\Entitlement;
+use StudentAffairsUwm\Shibboleth\ConfigurationBackwardsCompatabilityMapper;
 
 class ShibbolethController extends Controller
 {
@@ -78,6 +79,10 @@ public function login()
      */
     public function idpAuthenticate()
     {
+        if (empty(config('shibboleth.user'))) {
+            ConfigurationBackwardsCompatabilityMapper::map();
+        }
+
         foreach (config('shibboleth.user') as $local => $server) {
             $map[$local] = $this->getServerVariable($server);
         }

tests/ShibbolethControllerTest.php

@@ -29,4 +29,30 @@ public function test_creates_user()
 
         $this->assertSame('100000001', $getJeff()->student_id);
     }
+
+    public function test_handles_backwards_compatability_config()
+    {
+        $backup = config('shibboleth.user');
+        config(['shibboleth.user' => null]);
+
+        config([
+            'shibboleth.idp_login_email'       => 'mail',
+            'shibboleth.idp_login_name'        => 'displayName',
+            'shibboleth.idp_login_first_name'  => 'givenName',
+            'shibboleth.idp_login_last_name'   => 'sn',
+            'shibboleth.idp_login_entitlement' => 'entitlement',
+        ]);
+
+        $getJeff = function(){
+            return User::where('email', '[email protected]')->first();
+        };
+
+        $this->assertEmpty($getJeff());
+
+        (new ShibbolethController)->idpAuthenticate();
+
+        $this->assertSame('Puckett', $getJeff()->last_name);
+
+        config(['shibboleth.user' => $backup]);
+    }
 }