This repository has been archived by the owner on Jul 23, 2024. It is now read-only.
(FIX) Restoring the Library title on the Library screen #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for looking into this! I think ideally the design would be such that the nav bar only appears on scroll, so as to prevent the clashing of text on scroll. However, I'm guessing that's not really possible / supported? If it's not then I think I'm good to merge this and just accept that we can't have what the design calls for. Cheers! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #689
It looks like the Navigation title was removed on purpose. I assume it was done to save a bit of extra space for the rest of content.
I've brought the navigation title back but kept it inline as a compromise between the scrolling issue and still having sufficient amount of space.