Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetch Asset.Data in search results #196

Closed
bsushmith opened this issue Jan 16, 2023 · 2 comments · Fixed by #197
Closed

fetch Asset.Data in search results #196

bsushmith opened this issue Jan 16, 2023 · 2 comments · Fixed by #197

Comments

@bsushmith
Copy link
Member

Is your feature request related to a problem? Please describe.
SearchResult does not have Data attribute. If we want to return and show some details from the Asset Data, that cannot be currently returned through the search results.

Describe the solution you'd like
Add Data attribute to SearchResult so that Asset Data can be returned through the search API.

@sudo-suhas
Copy link
Contributor

Can we make this opt-in? data can contain quite a lot of information that can significantly increase the size of the response.

@ravisuhag
Copy link
Member

@bsushmith @sudo-suhas @StewartJingga I think we should keep search results very lean and search should only be used for full text search. Search's intention should not be to return all data. List API should take care of this.
Similar point for this. #203
We can close this issue for now that it is included. I will try to sum up search vs list in another issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants