Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data] Dataset.train_test_split reads dataset twice #51223

Open
bveeramani opened this issue Mar 10, 2025 · 0 comments
Open

[Data] Dataset.train_test_split reads dataset twice #51223

bveeramani opened this issue Mar 10, 2025 · 0 comments
Labels
data Ray Data-related issues P2 Important issue, but not time-critical performance

Comments

@bveeramani
Copy link
Member

What happened + What you expected to happen

I'm following the Fine-tuning a Torch object detection model example, and noticed when I call train_test_split the dataset is read twice.

I think it's because we call Dataset.count() in the method's implementation, and for non-trivial pipelines this causes the pipeline to execute.

ds_length = ds.count()

Versions / Dependencies

902b55a

Reproduction script

See descripition.

Issue Severity

Low: It annoys or frustrates me.

@bveeramani bveeramani added data Ray Data-related issues P2 Important issue, but not time-critical performance labels Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data Ray Data-related issues P2 Important issue, but not time-critical performance
Projects
None yet
Development

No branches or pull requests

1 participant