Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Add c++ API for setting max_task_retries #51205

Open
patrickiamy opened this issue Mar 10, 2025 · 1 comment
Open

[Core] Add c++ API for setting max_task_retries #51205

patrickiamy opened this issue Mar 10, 2025 · 1 comment
Labels
C++-Worker core Issues that should be addressed in Ray Core enhancement Request for new feature and/or capability P2 Important issue, but not time-critical

Comments

@patrickiamy
Copy link

patrickiamy commented Mar 10, 2025

Description

It seems there is no way to set max_task_retries with c++ API. Could we add related API? It's important for enabling fault tolerance in c++ applications based on Ray.

Possible implementation

We may make the following change to enable users to set the option?

master/cpp/include/ray/api/actor_creator.h
Add an API for max_task_retries

master/cpp/include/ray/api/task_options.h
Add the option into ActorCreationOptions

master/cpp/src/ray/runtime/task/native_task_submitter.cc
Pass the option to ray::core::ActorCreationOptions in NativeTaskSubmitter::CreateActor function

@patrickiamy patrickiamy added enhancement Request for new feature and/or capability triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Mar 10, 2025
@jcotant1 jcotant1 added the core Issues that should be addressed in Ray Core label Mar 10, 2025
@jjyao jjyao added P2 Important issue, but not time-critical C++-Worker and removed triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Mar 10, 2025
@jjyao
Copy link
Collaborator

jjyao commented Mar 10, 2025

Hi @patrickiamy feel free to contribute!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++-Worker core Issues that should be addressed in Ray Core enhancement Request for new feature and/or capability P2 Important issue, but not time-critical
Projects
None yet
Development

No branches or pull requests

3 participants