Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Fix ray util bazel build files #49928

Closed
dentiny opened this issue Jan 18, 2025 · 1 comment
Closed

[core] Fix ray util bazel build files #49928

dentiny opened this issue Jan 18, 2025 · 1 comment
Assignees
Labels
core Issues that should be addressed in Ray Core enhancement Request for new feature and/or capability P2 Important issue, but not time-critical

Comments

@dentiny
Copy link
Contributor

dentiny commented Jan 18, 2025

Description

Current bazel BUILD file rules is completely a messy, should split all targets:

ray/src/ray/util/BUILD

Lines 3 to 40 in 5e42bdd

ray_cc_library(
name = "util",
srcs = glob(
[
"*.cc",
],
exclude = [
"*_test.cc",
],
),
hdrs = glob([
"*.h",
]),
linkopts = select({
"@platforms//os:windows": [],
"//conditions:default": ["-lpthread"],
}),
deps = [
":thread_checker",
"//:aligned_alloc",
"//:sha256",
"//src/ray/protobuf:event_cc_proto",
"//src/ray/protobuf:export_event_cc_proto",
"@boost//:asio",
"@com_github_spdlog//:spdlog",
"@com_google_absl//absl/container:flat_hash_map",
"@com_google_absl//absl/container:flat_hash_set",
"@com_google_absl//absl/debugging:failure_signal_handler",
"@com_google_absl//absl/debugging:stacktrace",
"@com_google_absl//absl/debugging:symbolize",
"@com_google_absl//absl/random",
"@com_google_absl//absl/synchronization",
"@com_google_absl//absl/time",
"@com_google_googletest//:gtest_main",
"@com_google_protobuf//:protobuf",
"@nlohmann_json",
],
)

Use case

No response

@dentiny dentiny added core Issues that should be addressed in Ray Core enhancement Request for new feature and/or capability P2 Important issue, but not time-critical labels Jan 18, 2025
@dentiny dentiny self-assigned this Jan 18, 2025
@dentiny
Copy link
Contributor Author

dentiny commented Jan 23, 2025

Mostly addressed with #49938, will followup with other cleanup PRs.

@dentiny dentiny closed this as completed Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Issues that should be addressed in Ray Core enhancement Request for new feature and/or capability P2 Important issue, but not time-critical
Projects
None yet
Development

No branches or pull requests

1 participant