You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Remove unused config parameter from V1 XGBoost training function
Bug identified by cursor bot: The _xgboost_train_fn_per_worker function
had an unused 'config' parameter that was never utilized. This parameter
was misleading because:
1. All XGBoost training parameters are in 'xgboost_train_kwargs' which
is bound via functools.partial
2. V1 XGBoostTrainer doesn't use train_loop_config pattern
3. The config parameter served no purpose and made the code confusing
Fix: Removed the config parameter and updated docstring to clarify this
is an internal V1 function where all parameters are pre-bound via partial,
unlike the V2 pattern where user functions receive train_loop_config.
This makes the V1 trainer's implementation pattern clearer and removes
confusion about parameter usage.
Signed-off-by: soffer-anyscale <[email protected]>
0 commit comments