Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode requests using Grammars #26

Open
rawleyfowler opened this issue Jan 14, 2023 · 5 comments
Open

Encode requests using Grammars #26

rawleyfowler opened this issue Jan 14, 2023 · 5 comments
Labels
enhancement New feature or request help wanted Extra attention is needed investigate Something worth investigating, but not necesarilly worth fixing until the investigation is complete.

Comments

@rawleyfowler
Copy link
Owner

Right now requests are encoded very naively, we can use grammars to make this better.

@rawleyfowler rawleyfowler changed the title Encode requests using Grammars` Encode requests using Grammars Jan 15, 2023
@masukomi
Copy link
Contributor

masukomi commented Jan 21, 2023

Are you suggesting using a grammar to replace

get('/', -> $request, $response {
    $response.html('<h1>Hello World</h1>');
});

so that it isn't something that LOOKS like a function body but is actually just a param passed to a function?

Because if so I am 100% in support of this.

@rawleyfowler
Copy link
Owner Author

@masukomi
Yeah I would like to make some sort of slang or grammar to do that

@rawleyfowler
Copy link
Owner Author

Obviously the current way will still have to exist to keep backwards compatibility.

@rawleyfowler rawleyfowler added the enhancement New feature or request label Jan 23, 2023
@masukomi
Copy link
Contributor

masukomi commented Jan 30, 2023

Obviously the current way will still have to exist to keep backwards compatibility.

this is early enough that i don't think it's bad to break backwards compatibility. a) there's hardly anyone using it b) it was pretty clear it was very early stages c) they can just pin it to the old version if it matters to them.

I don't think it's worth maintaining tech debt indefinitely for such a small number of users and actual instances of the code in action.

@rawleyfowler
Copy link
Owner Author

I'm thinking that maybe the grammar can translate to the current scheme. We'll see though. Still pretty up in the air on how we should approach this.

@rawleyfowler rawleyfowler added help wanted Extra attention is needed investigate Something worth investigating, but not necesarilly worth fixing until the investigation is complete. labels May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed investigate Something worth investigating, but not necesarilly worth fixing until the investigation is complete.
Projects
None yet
Development

No branches or pull requests

2 participants