-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zernike Polynomial Random Inputs Test Case Failing #260
Comments
@JoshVStaden Could you please take a look? You'll need to check out the latest dask-tf-1.4 branch of montblanc. |
@sjperkins I updated my Montblanc fork to match yours, and I can't seem to install it. It seems to fail at compile time, and I get the following issues:
These seem to be syntax and declaration issues in general, which is strange because I imagine you aren't having any of these your side. |
@JoshVStaden The required version of tensorflow changed (to 1.12.0 I believe). Out of interest how are you setting this up and installing this? At the very least you should be running this in a virtual environment and running: $ pip install ~/code/montblanc I would expect the above to complain about the tensorflow version. |
@sjperkins I did notice that the required tensorflow version changed, and I managed to install the latest version without any issues. I am running it in a virtual environment, and the command that I run is |
Are you in the dask-tf-1.4 branch? |
Yes |
Ping me on hangouts? |
I'm unfortunately in PE for the day, I'll only be back late this afternoon |
@sjperkins Hi Simon, do you still need to do a Hangouts? |
The Zernike polynomial random_inputs test case seems to be failing on the dask-tf-1.4 branch. It seems to be outputting zeros or nans for the random inputs. The test case should be updated so that representative random input produces some reasonable output.
I've made some updates to the test cases mostly to improve formatting and to make the comparison tolerances more consistent across single and double precision. I haven't modified the actual operator code. See the difference here 3261196...1fee29b
The text was updated successfully, but these errors were encountered: