Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to include parallactic angle term in net gain #329

Open
landmanbester opened this issue Feb 21, 2024 · 0 comments
Open

Add option to include parallactic angle term in net gain #329

landmanbester opened this issue Feb 21, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@landmanbester
Copy link
Collaborator

Describe the problem that the feature should address
The current apply_p_jones options only allow applying paralactic angle (or its inverse) on the fly. This is not compatible with the idea of applying gains on the fly during imaging.

Describe the solution you'd like
It should be possible to add the parallactic angle jones term to the net gain output. This way there is no ambiguity in the order in which terms are applied.

Describe alternatives you've considered
I have considered doing this inside the imager but I think it is cleaner to add it to the net gain because i) it avoids duplicating the calculation (and possibly getting it wrong somewhere) ii) there are fewer parallactic angle related options to confuse the user with and iii) there is less chance of messing up the order in which terms get applied. The latter becomes especially true when there are direction dependent gains involved.

@landmanbester landmanbester added the enhancement New feature or request label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant