Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify users early if keymanagementprovider resource does not exist #1452

Open
1 task
yizha1 opened this issue May 7, 2024 · 3 comments
Open
1 task

Notify users early if keymanagementprovider resource does not exist #1452

yizha1 opened this issue May 7, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@yizha1
Copy link
Collaborator

yizha1 commented May 7, 2024

What would you like to be added?

I configured the cosign verifier with non-existing keymanagementprovider resource, the command kubectl get verifier cosign-verifier indicated a success. However, when I started to deploy an image, the deployment failed as expected. The Ratify log showed the keymanagementprovider resource did not exist.

Anything else you would like to add?

Is it feasible to proactively notify users about configuration issues? In real-world scenarios, typos or other configuration errors can occur. For instance, when users run kubectl get verifier to check the status, everything might appear fine initially. However, these configuration issues may only surface during image deployment. In large-scale deployments, multiple error logs related to the same configuration issue can accumulate, which could be better avoided to conserve cluster resources.

Are you willing to submit PRs to contribute to this feature?

  • Yes, I am willing to implement it.
@yizha1 yizha1 added enhancement New feature or request triage Needs investigation labels May 7, 2024
@akashsinghal akashsinghal self-assigned this Jun 3, 2024
@susanshi
Copy link
Collaborator

Verifier and KMPs are reconciled separately, is there a way to guarantee the order?

@susanshi
Copy link
Collaborator

Discussion from PR review: We have two options:

  1. The verifier would error out if referenced KMP was not found ( so a retry could be triggered)
  2. We could print a warning that KMP did not exist, and move on.

@binbin-li
Copy link
Collaborator

As we discussed in the PR review meeting, we could also investigate the path that makes KMP reconciler to trigger Verifier reconciliation.

@binbin-li binbin-li removed the triage Needs investigation label Jul 25, 2024
@binbin-li binbin-li added this to the v1.4.0 milestone Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants