Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not handling millis() rollovers #261

Open
jgstroud opened this issue Dec 22, 2024 · 2 comments
Open

Not handling millis() rollovers #261

jgstroud opened this issue Dec 22, 2024 · 2 comments

Comments

@jgstroud
Copy link
Collaborator

The code is so stable now that my millis() counter actually rolled rover.
https://docs.arduino.cc/language-reference/en/functions/time/millis/

My uptime had mysteriously gone back to 0, which originally I thought there must have been a power flicker. But there was nothing in the logs. Then today I clicked the wall button and the device went into recovery mode after a single press. I went back and reviewed my syslog logs and see that the counter reset timeout value was set before the rollover.

@jameyers4
Copy link

I, for one, would appreciate this change incorporated into 1.8.3 at earliest reasonable convenience. I was closing in on 40 days when I had to power down for non RATDGO reasons - I was close (-ish) to the 32 bit counter limit…

@jgstroud
Copy link
Collaborator Author

PR is available. There is no way to artificially test this as far as I can tell. I'm debating whether I should just merge it now or wait 50 days to verify it properly handles rollovers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants