-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: crates-tui based async tutorial #440
base: main
Are you sure you want to change the base?
Conversation
Deploying with
|
Latest commit: |
b77a2c2
|
Status: | ✅ Deploy successful! |
Preview URL: | https://4c4d41f8.ratatui.pages.dev |
Branch Preview URL: | https://kd-async-tutorial.ratatui.pages.dev |
The crates-tui still has a lot of complexity that might be mitigated first to make it easier to explain in the context of a tutorial: |
94fff65
to
897bb93
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider how you went about building this incrementally yourself. There would have been many points where you stopped and ran the application. The order which this is presented as a tutorial doesn't allow for that approach. I wonder if it should. To do that you would need to move the widgets and draw earlier, incrementally add functionality, etc. E.g. maybe consider having a specific result type that is pre-formatted, instead of just wrapping the api type. When you then add the actual calls, this just become a mapping rather than implementing behavior.
7168bb6
to
2c518f7
Compare
ed4293f
to
5e3f562
Compare
77aded8
to
9b0abb5
Compare
Partial review:
Crates IO API Helper | Ratatui
|
@kdheepak's goals were:
I recrafted these a little:
Tutorials shouldn't generally be the place where the canonical information about why to do things lies (as their text should generally be aligned with the goal of the tutorial rather than ratatui apps as a whole. So we should eagerly identify parts of the tutorial to split out and write about elsewhere: e.g. "Want to go deeper on this topic, see https://ratatui.rs/how-to/test-widgets ..." |
No description provided.