Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Airstream users, do you use emitOnce = true / false? How much and why? #58

Closed
raquo opened this issue Dec 30, 2020 · 2 comments
Closed

Airstream users, do you use emitOnce = true / false? How much and why? #58

raquo opened this issue Dec 30, 2020 · 2 comments
Labels
question Further information is requested

Comments

@raquo
Copy link
Owner

raquo commented Dec 30, 2020 •
edited
Loading

Question prompted by @ajaychandran's suggestion in another issue / pr to make this part of the API smoother.

The methods EventStream.fromSeq, EventStream.fromValue and EventStream.fromTry currently require you to specify this parameter. It's not optional because originally I wasn't sure what the default should be. My impression right now is that emitOnce = false is the most reasonable default.

So I'm inclined to add a default value for this paramtere, emitOnce = false, or, if people are actually using emitOnce = true for good reasons, to provide separate fromSeqOnce / fromValueOnce / fromTryOnce methods.
@raquo
Copy link
Owner Author

raquo commented Dec 30, 2020 •
edited
Loading

Link to original suggestion: #54 (comment) (please comment on this here, not in #54)

@ngbinh
Copy link
Sponsor Contributor

ngbinh commented Dec 30, 2020

I am slightly inclined to the the change with default parameter.

@ajaychandran ajaychandran changed the title Airstream ysers, do you use emitOnce = true / false? How much and why? Airstream users, do you use emitOnce = true / false? How much and why? Dec 30, 2020
@raquo raquo added the question Further information is requested label Dec 31, 2020
raquo added a commit that referenced this issue Jan 5, 2021
@raquo
API: Default emitOnce param to false in EventStream.{fromSeq, fromVal…
707ea07 
…ue, fromTry}

Fixes #58
@raquo raquo closed this as completed Jan 5, 2021
raquo added a commit that referenced this issue Feb 26, 2021
@raquo
API: Default emitOnce param to false in EventStream.{fromSeq, fromVal…
fdee555 
…ue, fromTry}

Fixes #58
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ngbinh @raquo