Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Consolidate template parameters #370

Open
benfred opened this issue Oct 2, 2024 · 0 comments
Open

[FEA] Consolidate template parameters #370

benfred opened this issue Oct 2, 2024 · 0 comments
Labels
feature request New feature or request

Comments

@benfred
Copy link
Member

benfred commented Oct 2, 2024

We've had to add template parameters for both int64_t and int32 indices in the public api. We should consolidate these types to a single integral type where possible in the public api.

For functions like pairwise distances that benefit from working on int32 sized data, we should dispatch privately from int64_t to int32_t - and potentially tile the calculations for large inputs.

We should also examine consolidating the double and single precision float inputs : I believe that faiss only supports float32 data, and that might also be an option here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant